From: Gary Yang <gary.yang@cixtech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP S32 Linux Team <s32@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Fugang Duan <fugang.duan@cixtech.com>,
CIX Linux Kernel Upstream Group <cix-kernel-upstream@cixtech.com>,
Del Regno <angelogioacchino.delregno@somainline.org>,
Rahul Tanwar <rahul.tanwar@linux.intel.com>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Krishna Potthuri <sai.krishna.potthuri@amd.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: Use consistent indentation in the example
Date: Mon, 14 Sep 2026 10:21:54 +0800 [thread overview]
Message-ID: <aqdaQgd2zD7p5GDU@gary-System-Product-Name> (raw)
In-Reply-To: <20260913123223.99893-2-krzysztof.kozlowski@oss.qualcomm.com>
On 2026-09-13 14:32, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> Correct indentation in the examples to consistent 2- or 4-spaces
> indentation to fix dt-check-style warnings ("example 0
> [indent-consistent] indent mismatch ..."). Preferred is 4-spaces, but
> re-indenting entire example just for that is too much churn.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
For the cix part:
Reviewed-by: Gary Yang <gary.yang@cixtech.com>
> ---
> .../pinctrl/awinic,aw9523-pinctrl.yaml | 50 +++++++++----------
> .../bindings/pinctrl/cix,sky1-pinctrl.yaml | 2 +-
> .../bindings/pinctrl/fsl,imx7d-pinctrl.yaml | 8 +--
> .../bindings/pinctrl/intel,lgm-io.yaml | 14 +++---
> .../pinctrl/mediatek,mt8183-pinctrl.yaml | 4 +-
> .../pinctrl/mediatek,mt8195-pinctrl.yaml | 2 +-
> .../bindings/pinctrl/qcom,hawi-tlmm.yaml | 4 +-
> .../bindings/pinctrl/qcom,kaanapali-tlmm.yaml | 4 +-
> .../bindings/pinctrl/qcom,maili-tlmm.yaml | 4 +-
> .../bindings/pinctrl/semtech,sx1501q.yaml | 4 +-
> .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 46 ++++++++---------
> 11 files changed, 71 insertions(+), 71 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> index 98c310a3c63c..1c09c0fd4930 100644
> --- a/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> @@ -108,32 +108,32 @@ examples:
> #size-cells = <0>;
>
> aw9523: gpio-expander@58 {
> - compatible = "awinic,aw9523-pinctrl";
> - reg = <0x58>;
> - interrupt-parent = <&tlmm>;
> - interrupts = <50 IRQ_TYPE_EDGE_FALLING>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - gpio-ranges = <&tlmm 0 0 16>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - reset-gpios = <&tlmm 51 GPIO_ACTIVE_HIGH>;
> + compatible = "awinic,aw9523-pinctrl";
> + reg = <0x58>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <50 IRQ_TYPE_EDGE_FALLING>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&tlmm 0 0 16>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + reset-gpios = <&tlmm 51 GPIO_ACTIVE_HIGH>;
>
> - keyboard-matrix-col-pins {
> - pins = "gpio8", "gpio9", "gpio10", "gpio11",
> - "gpio12", "gpio13", "gpio14", "gpio15";
> - function = "gpio";
> - input-disable;
> - output-low;
> - };
> + keyboard-matrix-col-pins {
> + pins = "gpio8", "gpio9", "gpio10", "gpio11",
> + "gpio12", "gpio13", "gpio14", "gpio15";
> + function = "gpio";
> + input-disable;
> + output-low;
> + };
>
> - keyboard-matrix-row-pins {
> - pins = "gpio0", "gpio1", "gpio2", "gpio3",
> - "gpio4", "gpio5", "gpio6", "gpio7";
> - function = "gpio";
> - bias-pull-up;
> - drive-open-drain;
> - input-enable;
> - };
> + keyboard-matrix-row-pins {
> + pins = "gpio0", "gpio1", "gpio2", "gpio3",
> + "gpio4", "gpio5", "gpio6", "gpio7";
> + function = "gpio";
> + bias-pull-up;
> + drive-open-drain;
> + input-enable;
> + };
> };
> };
> diff --git a/Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
> index 8ed53496c386..4ab1f00775cc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
> @@ -86,6 +86,6 @@ examples:
> pinmux = <CIX_PAD_GPIO012_FUNC_GPIO012>;
> bias-pull-up;
> drive-strength = <8>;
> - };
> + };
> };
> };
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
> index 948160cfbc5f..7275215918bb 100644
> --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
> @@ -106,8 +106,8 @@ examples:
> fsl,input-sel = <&iomuxc>;
>
> pinctrl_gpio_lpsr: gpio1-grp {
> - fsl,pins =
> - <0x0008 0x0038 0x0000 0x0 0x0 0x59>,
> - <0x000C 0x003C 0x0000 0x0 0x0 0x59>;
> - };
> + fsl,pins =
> + <0x0008 0x0038 0x0000 0x0 0x0 0x59>,
> + <0x000C 0x003C 0x0000 0x0 0x0 0x59>;
> + };
> };
> diff --git a/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml b/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> index 1144ca2896e3..96c405711f65 100644
> --- a/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> @@ -64,13 +64,13 @@ examples:
> reg = <0xe2880000 0x100000>;
>
> uart0-pins {
> - pins = <64>, /* UART_RX0 */
> - <65>; /* UART_TX0 */
> - function = "CONSOLE_UART0";
> - pinmux = <1>,
> - <1>;
> - groups = "CONSOLE_UART0";
> - };
> + pins = <64>, /* UART_RX0 */
> + <65>; /* UART_TX0 */
> + function = "CONSOLE_UART0";
> + pinmux = <1>,
> + <1>;
> + groups = "CONSOLE_UART0";
> + };
> };
>
> ...
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml
> index 3db2438fadc7..4bcee7741fcd 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml
> @@ -221,8 +221,8 @@ examples:
>
> i2c0_pins_a: i2c0-pins {
> pins1 {
> - pinmux = <PINMUX_GPIO48__FUNC_SCL5>,
> - <PINMUX_GPIO49__FUNC_SDA5>;
> + pinmux = <PINMUX_GPIO48__FUNC_SCL5>,
> + <PINMUX_GPIO49__FUNC_SDA5>;
> mediatek,pull-up-adv = <3>;
> drive-strength-microamp = <1000>;
> };
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8195-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8195-pinctrl.yaml
> index 33cb71775db9..0bcafa78acb2 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8195-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8195-pinctrl.yaml
> @@ -234,7 +234,7 @@ examples:
> - |
> #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> - #
> +
> pio: pinctrl@10005000 {
> compatible = "mediatek,mt8195-pinctrl";
> reg = <0x10005000 0x1000>,
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,hawi-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,hawi-tlmm.yaml
> index 3b3961789860..2b1354e212e5 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,hawi-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,hawi-tlmm.yaml
> @@ -113,8 +113,8 @@ examples:
> #interrupt-cells = <2>;
>
> qup-uart7-state {
> - pins = "gpio62", "gpio63";
> - function = "qup1_se7";
> + pins = "gpio62", "gpio63";
> + function = "qup1_se7";
> };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,kaanapali-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,kaanapali-tlmm.yaml
> index 53534a07a1f0..ea7d4768483d 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,kaanapali-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,kaanapali-tlmm.yaml
> @@ -120,8 +120,8 @@ examples:
> #interrupt-cells = <2>;
>
> qup-uart7-state {
> - pins = "gpio62", "gpio63";
> - function = "qup1_se7";
> + pins = "gpio62", "gpio63";
> + function = "qup1_se7";
> };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,maili-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,maili-tlmm.yaml
> index 64fe90b2391b..a0b56adb3388 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,maili-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,maili-tlmm.yaml
> @@ -113,8 +113,8 @@ examples:
> #interrupt-cells = <2>;
>
> qup-uart7-state {
> - pins = "gpio62", "gpio63";
> - function = "qup1_se7";
> + pins = "gpio62", "gpio63";
> + function = "qup1_se7";
> };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
> index 39d7dad3313b..f7a7551d7f50 100644
> --- a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
> @@ -244,8 +244,8 @@ examples:
> interrupt-controller;
>
> gpio1-cfg {
> - pins = "gpio1";
> - bias-pull-up;
> + pins = "gpio1";
> + bias-pull-up;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> index ce66fd15ff9c..300d38f87f2d 100644
> --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml
> @@ -317,37 +317,37 @@ examples:
> #include <dt-bindings/pinctrl/pinctrl-zynqmp.h>
> zynqmp_firmware: zynqmp-firmware {
> pinctrl0: pinctrl {
> - compatible = "xlnx,zynqmp-pinctrl";
> + compatible = "xlnx,zynqmp-pinctrl";
>
> - pinctrl_uart1_default: uart1-default {
> - mux {
> - groups = "uart0_4_grp", "uart0_5_grp";
> - function = "uart0";
> - };
> + pinctrl_uart1_default: uart1-default {
> + mux {
> + groups = "uart0_4_grp", "uart0_5_grp";
> + function = "uart0";
> + };
>
> - conf {
> - groups = "uart0_4_grp";
> - slew-rate = <SLEW_RATE_SLOW>;
> - power-source = <IO_STANDARD_LVCMOS18>;
> - };
> + conf {
> + groups = "uart0_4_grp";
> + slew-rate = <SLEW_RATE_SLOW>;
> + power-source = <IO_STANDARD_LVCMOS18>;
> + };
>
> - conf-rx {
> - pins = "MIO18";
> - bias-pull-up;
> - };
> + conf-rx {
> + pins = "MIO18";
> + bias-pull-up;
> + };
>
> - conf-tx {
> - pins = "MIO19";
> - bias-disable;
> - input-schmitt-disable;
> - };
> - };
> + conf-tx {
> + pins = "MIO19";
> + bias-disable;
> + input-schmitt-disable;
> + };
> + };
> };
> };
>
> uart1 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_uart1_default>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart1_default>;
> };
>
> ...
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-09-14 2:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 12:32 [PATCH] dt-bindings: pinctrl: Use consistent indentation in the example Krzysztof Kozlowski
2026-09-14 2:21 ` Gary Yang [this message]
2026-09-14 8:05 ` Michal Simek
2026-09-16 17:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqdaQgd2zD7p5GDU@gary-System-Product-Name \
--to=gary.yang@cixtech.com \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=brgl@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@cixtech.com \
--cc=imx@lists.linux.dev \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=ping.bai@nxp.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=sai.krishna.potthuri@amd.com \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.