From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Tapio Reijonen <tapio.reijonen@vaisala.com>
Cc: Saravanan Sekar <sravanhome@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: mpq4210: Drop the mod_devicetable.h include
Date: Mon, 14 Sep 2026 09:22:37 +0200 [thread overview]
Message-ID: <aqeghbaA5yS8aO9R@monoceros> (raw)
In-Reply-To: <20260913-mpq4210-ohms-fixup-v1-3-dcff627001ff@vaisala.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
Hello,
On Sun, Sep 13, 2026 at 11:40:18AM +0000, Tapio Reijonen wrote:
> <linux/mod_devicetable.h> is meant to go away, and this driver does not
> need it: <linux/i2c.h> already supplies struct i2c_device_id and
> <linux/of.h> struct of_device_id, and both are included already.
>
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Link: https://lore.kernel.org/r/aqRMb8q7BT3uZ9iF@monoceros
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
thanks for picking up the suggestion.
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-14 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 11:40 [PATCH 0/3] regulator: mpq4210: Address the post-merge review comments Tapio Reijonen
2026-09-13 11:40 ` [PATCH 1/3] regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix Tapio Reijonen
2026-09-14 6:14 ` Krzysztof Kozlowski
2026-09-13 11:40 ` [PATCH 2/3] regulator: mpq4210: Use the -ohms feedback divider property Tapio Reijonen
2026-09-14 6:14 ` Krzysztof Kozlowski
2026-09-13 11:40 ` [PATCH 3/3] regulator: mpq4210: Drop the mod_devicetable.h include Tapio Reijonen
2026-09-14 7:22 ` Uwe Kleine-König [this message]
2026-09-14 10:13 ` [PATCH 0/3] regulator: mpq4210: Address the post-merge review comments Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqeghbaA5yS8aO9R@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tapio.reijonen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.