All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] ci: drop no-op gettext link on macOS
Date: Mon, 14 Sep 2026 09:53:02 +0200	[thread overview]
Message-ID: <aqen3lVdecDqo89w@pks.im> (raw)
In-Reply-To: <CAHwyqnUG_ta=m5e7rk-35D0Dve+GeQX3eNuFf_U4kSd5+Sqy+g@mail.gmail.com>

On Mon, Sep 14, 2026 at 08:57:49AM +0200, Harald Nordgren wrote:
> > So I'm still left wondering whether it really isn't required anymore,
> > and if so why it stopped being required. Links to passing GitHub and
> > GitLab pipelines with that change would've in this case also helped to
> > demonstrate that it works without that line.
> 
> It passed on GitHub: https://github.com/git/git/pull/2402
> 
> I'll take a look at the rest of your comments as well, thanks for the help!

If you look at the pipeline though you can see that almost all of the
jobs were skippped. And in particular, macOS wasn't tested at all.

Patrick

  reply	other threads:[~2026-09-14  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12  7:55 [PATCH] ci: drop no-op gettext link on macOS Harald Nordgren via GitGitGadget
2026-09-14  6:25 ` Patrick Steinhardt
2026-09-14  6:57   ` Harald Nordgren
2026-09-14  7:53     ` Patrick Steinhardt [this message]
2026-09-14  8:50       ` Harald Nordgren
2026-09-14  7:09 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-09-26  4:36   ` Junio C Hamano
2026-09-26 13:33     ` Harald Nordgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqen3lVdecDqo89w@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.