From: Huang Shijie <huangsj@hygon.cn>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <viro@zeniv.linux.org.uk>, <brauner@kernel.org>,
<zhongyuan@hygon.cn>, <fangbaoshun@hygon.cn>,
<yingzhiwei@hygon.cn>, <jack@suse.cz>, <dev.jain@arm.com>,
<ljs@kernel.org>, <akpm@linux-foundation.org>, <hpa@zytor.com>,
<ryan.roberts@arm.com>, <mjguzik@gmail.com>,
<joel.granados@kernel.org>, <jannh@google.com>, <oleg@redhat.com>,
<aleksa@amutable.com>, <legion@kernel.org>, <kees@kernel.org>,
<joannelkoong@gmail.com>, <tj@kernel.org>,
<libaokun@linux.alibaba.com>, <ebiggers@kernel.org>,
<sandeen@redhat.com>, <linux-fsdevel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] fs/drop_caches: do not scan procfs in drop_pagecache_sb()
Date: Mon, 14 Sep 2026 19:59:04 +0800 [thread overview]
Message-ID: <aqfhiHlogbbADDkP@hsj-2U-Workstation> (raw)
In-Reply-To: <c566b9eb-7cad-4a03-bf53-ae3b3e699559@p183>
On Mon, Sep 14, 2026 at 12:19:03PM +0300, Alexey Dobriyan wrote:
> On Mon, Sep 14, 2026 at 02:14:47PM +0800, Huang Shijie wrote:
> > There is no page cache for the procfs, so do not scan the
> > inodes in procfs.
>
> > @@ -20,6 +21,9 @@ static void drop_pagecache_sb(struct super_block *sb, void *unused)
> > {
> > struct inode *inode, *toput_inode = NULL;
> >
> > + if (sb->s_magic == PROC_SUPER_MAGIC)
> > + return;
>
> This should be some flag somewhere in superblock.
> Other fake filesystems don't support pagecache too.
yes.
It seems it is better to check like this:
if (sb->s_bdi == &noop_backing_dev_inf)
return;
next prev parent reply other threads:[~2026-09-14 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 6:14 [RFC PATCH 0/3] fs/proc: split the inode list for procfs Huang Shijie
2026-09-14 6:14 ` [RFC PATCH 1/3] fs/drop_caches: do not scan procfs in drop_pagecache_sb() Huang Shijie
2026-09-14 9:19 ` Alexey Dobriyan
2026-09-14 11:59 ` Huang Shijie [this message]
2026-09-14 12:10 ` Huang Shijie
2026-09-14 6:14 ` [RFC PATCH 2/3] fs/super: introduce a helper sb_inodes_empty() Huang Shijie
2026-09-14 6:14 ` [RFC PATCH 3/3] fs/proc: split the inode list Huang Shijie
2026-09-14 8:50 ` [syzbot ci] Re: fs/proc: split the inode list for procfs syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqfhiHlogbbADDkP@hsj-2U-Workstation \
--to=huangsj@hygon.cn \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aleksa@amutable.com \
--cc=brauner@kernel.org \
--cc=dev.jain@arm.com \
--cc=ebiggers@kernel.org \
--cc=fangbaoshun@hygon.cn \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=joannelkoong@gmail.com \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=legion@kernel.org \
--cc=libaokun@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mjguzik@gmail.com \
--cc=oleg@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=sandeen@redhat.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yingzhiwei@hygon.cn \
--cc=zhongyuan@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.