From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Loftus, Ciara" <ciara.loftus@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"rjarry@redhat.com" <rjarry@redhat.com>,
"cfontain@redhat.com" <cfontain@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v7 2/4] net/iavf: fix duplicate MAC addresses install
Date: Mon, 14 Sep 2026 13:02:02 +0100 [thread overview]
Message-ID: <aqfiOvgEZpOR_raG@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8xZMxZfwSDo=1TpeeV93BQA43RW+ctzkjnC5QnPZ9FQ9Q@mail.gmail.com>
On Mon, Sep 14, 2026 at 01:56:36PM +0200, David Marchand wrote:
> On Mon, 14 Sept 2026 at 12:19, Loftus, Ciara <ciara.loftus@intel.com> wrote:
> > > @@ -3428,6 +3428,14 @@ iavf_post_reset_reconfig(struct rte_eth_dev
> > > *dev)
> > > int ret = 0;
> > > bool allmulti = false, allunicast = false;
> > > struct iavf_adapter *adapter = IAVF_DEV_PRIVATE_TO_ADAPTER(dev-
> > > >data->dev_private);
> > > + struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data-
> > > >dev_private);
> > > +
> > > + /*
> > > + * After a VF reset, all MAC addresses got flushed.
> > > + * The primary MAC should have been set in iavf_dev_start, restore
> >
> > iavf_dev_start is not guaranteed to have been executed before this handler.
> > So I would change this comment to something like:
> > "The primary MAC has been or will be restored by iavf_dev_start".
> >
> > Other than that:
> >
> > Acked-by: Ciara Loftus <ciara.loftus@intel.com>
>
> Yes, true.
> I'll update in a new revision if needed, otherwise, could it be
> updated when applying?
>
Single line text changes I can handle on apply, no problem, so long as the
rest of the set is good to go.
/Bruce
next prev parent reply other threads:[~2026-09-14 12:02 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 9:18 [PATCH 0/4] Remove limitations coming from legacy VMDq David Marchand
2026-04-03 9:18 ` [PATCH 1/4] ethdev: skip VMDq pools unless configured David Marchand
2026-06-01 9:30 ` Andrew Rybchenko
2026-04-03 9:18 ` [PATCH 2/4] ethdev: announce VMDq capability David Marchand
2026-04-06 22:22 ` Kishore Padmanabha
2026-04-29 14:18 ` David Marchand
2026-05-18 22:12 ` Kishore Padmanabha
2026-06-01 9:32 ` Andrew Rybchenko
2026-04-03 9:18 ` [PATCH 3/4] ethdev: hide VMDq internal sizes David Marchand
2026-06-01 9:34 ` Andrew Rybchenko
2026-04-03 9:18 ` [PATCH 4/4] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-04-05 18:47 ` [PATCH 0/4] Remove limitations coming from legacy VMDq Stephen Hemminger
2026-04-29 14:22 ` David Marchand
2026-05-06 12:35 ` [PATCH v2 0/5] " David Marchand
2026-05-06 12:35 ` [PATCH v2 1/5] ethdev: skip VMDq pools unless configured David Marchand
2026-06-01 9:35 ` Andrew Rybchenko
2026-05-06 12:35 ` [PATCH v2 2/5] ethdev: announce VMDq capability David Marchand
2026-06-01 9:36 ` Andrew Rybchenko
2026-05-06 12:35 ` [PATCH v2 3/5] ethdev: hide VMDq internal sizes David Marchand
2026-05-06 12:35 ` [PATCH v2 4/5] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-05-06 12:35 ` [PATCH v2 5/5] net/iavf: fix duplicate MAC addresses install David Marchand
2026-05-07 2:51 ` [PATCH v2 0/5] Remove limitations coming from legacy VMDq Stephen Hemminger
2026-05-10 15:03 ` David Marchand
2026-05-10 17:03 ` [PATCH v3 " David Marchand
2026-05-10 17:03 ` [PATCH v3 1/5] ethdev: check VMDq availability David Marchand
2026-06-01 9:38 ` Andrew Rybchenko
2026-05-10 17:03 ` [PATCH v3 2/5] ethdev: skip VMDq pools unless configured David Marchand
2026-06-01 9:38 ` Andrew Rybchenko
2026-05-10 17:03 ` [PATCH v3 3/5] ethdev: hide VMDq internal sizes David Marchand
2026-06-01 9:39 ` Andrew Rybchenko
2026-05-10 17:03 ` [PATCH v3 4/5] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-05-12 14:41 ` Stephen Hemminger
2026-05-27 13:25 ` David Marchand
2026-05-10 17:03 ` [PATCH v3 5/5] net/iavf: fix duplicate MAC addresses install David Marchand
2026-07-09 16:02 ` [PATCH v4 00/10] Remove limitations coming from legacy VMDq David Marchand
2026-07-09 16:02 ` [PATCH v4 01/10] ethdev: check VMDq availability David Marchand
2026-07-09 16:02 ` [PATCH v4 02/10] ethdev: skip VMDq pools unless configured David Marchand
2026-07-09 16:02 ` [PATCH v4 03/10] ethdev: hide VMDq internal sizes David Marchand
2026-07-09 16:02 ` [PATCH v4 04/10] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-07-09 16:02 ` [PATCH v4 05/10] net/iavf: fix duplicate MAC addresses install David Marchand
2026-07-13 13:12 ` Loftus, Ciara
2026-07-13 14:10 ` David Marchand
2026-07-14 9:23 ` Loftus, Ciara
2026-07-09 16:02 ` [PATCH v4 06/10] net/mlx5: remove MAC addresses flush helper on Linux David Marchand
2026-07-09 16:02 ` [PATCH v4 07/10] net/mlx5: remove redundant MAC address index checks David Marchand
2026-07-09 16:02 ` [PATCH v4 08/10] net/mlx5: pass maximum number of unicast MAC to common code David Marchand
2026-07-09 16:02 ` [PATCH v4 09/10] net/mlx5: use bitset for tracking MAC addresses David Marchand
2026-07-09 16:02 ` [PATCH v4 10/10] net/mlx5: accept more unicast " David Marchand
2026-07-10 6:44 ` David Marchand
2026-07-10 7:48 ` David Marchand
2026-07-23 12:41 ` [PATCH v5 00/10] Remove limitations coming from legacy VMDq David Marchand
2026-07-23 12:41 ` [PATCH v5 01/10] ethdev: check VMDq availability David Marchand
2026-07-23 12:41 ` [PATCH v5 02/10] ethdev: skip VMDq pools unless configured David Marchand
2026-07-23 12:41 ` [PATCH v5 03/10] ethdev: hide VMDq internal sizes David Marchand
2026-07-23 12:41 ` [PATCH v5 04/10] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-07-23 12:41 ` [PATCH v5 05/10] net/iavf: fix duplicate MAC addresses install David Marchand
2026-07-23 12:41 ` [PATCH v5 06/10] net/mlx5: remove MAC addresses flush helper on Linux David Marchand
2026-07-23 12:41 ` [PATCH v5 07/10] net/mlx5: remove redundant MAC address index checks David Marchand
2026-07-23 12:41 ` [PATCH v5 08/10] net/mlx5: pass maximum number of unicast MAC to common code David Marchand
2026-07-23 17:35 ` Stephen Hemminger
2026-07-23 12:41 ` [PATCH v5 09/10] net/mlx5: use bitset for tracking MAC addresses David Marchand
2026-07-23 12:41 ` [PATCH v5 10/10] net/mlx5: accept more unicast " David Marchand
2026-07-27 7:20 ` [PATCH v5 00/10] Remove limitations coming from legacy VMDq David Marchand
2026-08-24 11:42 ` [PATCH v6 0/3] " David Marchand
2026-08-24 11:42 ` [PATCH v6 1/3] ethdev: check VMDq availability David Marchand
2026-08-24 11:42 ` [PATCH v6 2/3] ethdev: skip VMDq pools unless configured David Marchand
2026-08-24 16:21 ` Stephen Hemminger
2026-08-24 16:24 ` David Marchand
2026-08-24 16:39 ` Stephen Hemminger
2026-08-24 11:42 ` [PATCH v6 3/3] ethdev: hide VMDq internal sizes David Marchand
2026-08-24 17:01 ` [PATCH v6 0/3] Remove limitations coming from legacy VMDq Stephen Hemminger
2026-09-04 12:28 ` [PATCH v6 1/2] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-09-04 12:28 ` [PATCH v6 2/2] net/iavf: fix duplicate MAC addresses install David Marchand
2026-09-09 9:39 ` Loftus, Ciara
2026-09-11 14:14 ` David Marchand
2026-09-11 15:37 ` David Marchand
2026-09-11 16:26 ` David Marchand
2026-09-10 10:24 ` [PATCH v6 1/2] net/iavf: accept up to 32k unicast MAC addresses Burakov, Anatoly
2026-09-11 9:37 ` Burakov, Anatoly
2026-09-11 11:52 ` David Marchand
2026-09-11 12:14 ` Burakov, Anatoly
2026-09-10 12:13 ` Burakov, Anatoly
2026-09-10 12:20 ` Burakov, Anatoly
2026-09-10 12:30 ` David Marchand
2026-09-10 12:38 ` Burakov, Anatoly
2026-09-08 9:27 ` [PATCH v6 1/5] net/mlx5: remove MAC addresses flush helper on Linux David Marchand
2026-09-08 9:27 ` [PATCH v6 2/5] net/mlx5: remove redundant MAC address index checks David Marchand
2026-09-11 8:36 ` Dariusz Sosnowski
2026-09-08 9:27 ` [PATCH v6 3/5] net/mlx5: pass maximum number of unicast MAC to common code David Marchand
2026-09-11 8:38 ` Dariusz Sosnowski
2026-09-08 9:27 ` [PATCH v6 4/5] net/mlx5: use bitset for tracking MAC addresses David Marchand
2026-09-11 8:40 ` Dariusz Sosnowski
2026-09-08 9:27 ` [PATCH v6 5/5] net/mlx5: accept more unicast " David Marchand
2026-09-11 8:59 ` Dariusz Sosnowski
2026-09-11 9:55 ` David Marchand
2026-09-11 10:01 ` Dariusz Sosnowski
2026-09-11 8:35 ` [PATCH v6 1/5] net/mlx5: remove MAC addresses flush helper on Linux Dariusz Sosnowski
2026-09-14 8:17 ` [PATCH v7 1/4] net/iavf: fix MAC addresses leak on reset David Marchand
2026-09-14 8:17 ` [PATCH v7 2/4] net/iavf: fix duplicate MAC addresses install David Marchand
2026-09-14 10:19 ` Loftus, Ciara
2026-09-14 11:56 ` David Marchand
2026-09-14 12:02 ` Bruce Richardson [this message]
2026-09-14 12:27 ` David Marchand
2026-09-23 11:53 ` Burakov, Anatoly
2026-09-14 8:17 ` [PATCH v7 3/4] net/iavf: add a helper for sending MAC addresses to PF David Marchand
2026-09-23 12:04 ` Burakov, Anatoly
2026-09-14 8:17 ` [PATCH v7 4/4] net/iavf: accept up to 32k unicast MAC addresses David Marchand
2026-09-23 12:14 ` Burakov, Anatoly
2026-09-14 10:15 ` [PATCH v7 1/4] net/iavf: fix MAC addresses leak on reset Loftus, Ciara
2026-09-14 11:54 ` David Marchand
2026-09-14 11:57 ` Loftus, Ciara
2026-09-23 11:47 ` Burakov, Anatoly
2026-09-23 14:37 ` Bruce Richardson
2026-09-14 14:42 ` [PATCH v7 1/5] net/mlx5: remove MAC addresses flush helper on Linux David Marchand
2026-09-14 14:42 ` [PATCH v7 2/5] net/mlx5: remove redundant MAC address index checks David Marchand
2026-09-21 8:31 ` Raslan Darawsheh
2026-09-21 10:06 ` David Marchand
2026-09-14 14:42 ` [PATCH v7 3/5] net/mlx5: pass maximum number of unicast MAC to common code David Marchand
2026-09-21 8:31 ` Raslan Darawsheh
2026-09-21 10:07 ` David Marchand
2026-09-14 14:42 ` [PATCH v7 4/5] net/mlx5: use bitset for tracking MAC addresses David Marchand
2026-09-14 14:42 ` [PATCH v7 5/5] net/mlx5: accept more unicast " David Marchand
2026-09-14 14:51 ` Dariusz Sosnowski
2026-09-21 8:31 ` Raslan Darawsheh
2026-09-21 8:31 ` [PATCH v7 1/5] net/mlx5: remove MAC addresses flush helper on Linux Raslan Darawsheh
2026-09-21 10:31 ` David Marchand
2026-09-21 11:02 ` Raslan Darawsheh
2026-09-21 11:50 ` [PATCH v8 " David Marchand
2026-09-21 11:50 ` [PATCH v8 2/5] net/mlx5: remove redundant MAC address index checks David Marchand
2026-09-21 11:50 ` [PATCH v8 3/5] net/mlx5: pass maximum number of unicast MAC to common code David Marchand
2026-09-21 11:50 ` [PATCH v8 4/5] net/mlx5: use bitset for tracking MAC addresses David Marchand
2026-09-21 11:50 ` [PATCH v8 5/5] net/mlx5: accept more unicast " David Marchand
2026-09-21 11:52 ` David Marchand
2026-09-23 11:55 ` Raslan Darawsheh
2026-09-24 6:38 ` [PATCH v9 1/5] net/mlx5: remove MAC addresses flush helper on Linux David Marchand
2026-09-24 6:38 ` [PATCH v9 2/5] net/mlx5: remove redundant MAC address index checks David Marchand
2026-09-29 12:50 ` Raslan Darawsheh
2026-09-24 6:38 ` [PATCH v9 3/5] net/mlx5: pass maximum number of unicast MAC to common code David Marchand
2026-09-29 12:50 ` Raslan Darawsheh
2026-09-24 6:38 ` [PATCH v9 4/5] net/mlx5: use bitset for tracking MAC addresses David Marchand
2026-09-29 12:50 ` Raslan Darawsheh
2026-09-24 6:38 ` [PATCH v9 5/5] net/mlx5: accept more unicast " David Marchand
2026-09-28 14:40 ` Dariusz Sosnowski
2026-09-29 12:50 ` Raslan Darawsheh
2026-09-29 13:24 ` David Marchand
2026-09-29 12:50 ` [PATCH v9 1/5] net/mlx5: remove MAC addresses flush helper on Linux Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqfiOvgEZpOR_raG@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=cfontain@redhat.com \
--cc=ciara.loftus@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.