Re: [PATCH] hwmon: (pmbus) Validate number of phases per page

["Nuno Sá" <nuno.sa@analog.com>]

On Sat, Sep 12, 2026 at 07:50:38AM -0700, Guenter Roeck wrote:
> It is possible for a PMBus driver to configure a phase count larger than
> the PMBUS_PHASES limit and cause an out-of-bounds read.
> 
> Add a bounds check for info->phases against PMBUS_PHASES in the core API
> to prevent the potential out-of-bounds read.
> 
> Cc: Nuno Sá <nuno.sa@analog.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Looks like sashiko comment does not apply with the patch on the max20826
series. Hence:

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  drivers/hwmon/pmbus/pmbus_core.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 5104fd29307b..d69f1bde1795 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -2982,6 +2982,11 @@ static int pmbus_init_common(struct i2c_client *client, struct pmbus_data *data,
>  	}
>  
>  	for (page = 0; page < info->pages; page++) {
> +		if (info->phases[page] > PMBUS_PHASES) {
> +			dev_err(dev, "Bad number of PMBus phases for page %d: %d\n",
> +				page, info->phases[page]);
> +			return -ENODEV;
> +		}
>  		ret = pmbus_identify_common(client, data, page);
>  		if (ret < 0) {
>  			dev_err(dev, "Failed to identify chip capabilities\n");
> -- 
> 2.45.2
>