From: Sana Sharma <sansshar@redhat.com>
To: linux-rt-users@vger.kernel.org
Cc: jkacur@redhat.com
Subject: [PATCH v4] rteval: Added unit tests for stress-ng validation functions
Date: Mon, 14 Sep 2026 14:08:55 -0400 [thread overview]
Message-ID: <aqg4N_eb0qE3Mrbd@fedora> (raw)
Used the python unittest capability to add tests that check the
code paths added in commit aecc7c6e47d4 ("rteval: Adding stressor
validation for stress-ng").
Signed-off-by: Sana Sharma <sansshar@redhat.com>
---
v4 of this patch changed the commit sha in the commit message to
be compliant with style requirements and removed main.
---
tests/test_stressng.py | 53 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 tests/test_stressng.py
diff --git a/tests/test_stressng.py b/tests/test_stressng.py
new file mode 100644
index 0000000..ba21c7d
--- /dev/null
+++ b/tests/test_stressng.py
@@ -0,0 +1,53 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright 2026 Sana Sharma <sansshar@redhat.com>
+
+""" Unit tests for the new stressng input validation """
+
+import sys
+import subprocess
+import unittest
+from unittest.mock import patch, MagicMock
+
+sys.path.insert(0, '.')
+from rteval.modules.loads import stressng
+
+class TestGetValidStressors(unittest.TestCase):
+ """Test suite for the function get_valid_stressors"""
+
+ @patch('rteval.modules.loads.stressng.subprocess.run')
+ def test_parses_stressor_list(self, mock_run):
+ """Tests that the function works for multiple correct inputs"""
+ mock_run.return_value = MagicMock(stdout="cpu vm matrix\n")
+ self.assertEqual(stressng.get_valid_stressors(), ['cpu', 'vm', 'matrix'])
+
+ @patch('rteval.modules.loads.stressng.subprocess.run',
+ side_effect=FileNotFoundError)
+ def test_not_installed_exits(self, _):
+ """Tests that the program exits correctly if stress-ng is not installed"""
+ with self.assertRaises(SystemExit) as cm:
+ stressng.get_valid_stressors()
+ self.assertEqual(cm.exception.code, 1)
+
+ @patch('rteval.modules.loads.stressng.subprocess.run',
+ side_effect=subprocess.CalledProcessError(1, 'stress-ng'))
+ def test_query_failure_exits(self, _):
+ """Tests that the program exits correctly if the query attempt fails"""
+ with self.assertRaises(SystemExit):
+ stressng.get_valid_stressors()
+
+class TestValidateStressor(unittest.TestCase):
+ """Test suite for the function validate_stressor"""
+
+ @patch('rteval.modules.loads.stressng.get_valid_stressors',
+ return_value=['cpu', 'vm'])
+ def test_valid_passes(self, _):
+ """Tests that the function works for correct inputs"""
+ stressng.validate_stressor('cpu') # should not raise
+
+ @patch('rteval.modules.loads.stressng.get_valid_stressors',
+ return_value=['cpu', 'vm'])
+ def test_invalid_exits(self, _):
+ """Tests that the function exits properly for incorrect inputs"""
+ with self.assertRaises(SystemExit) as cm:
+ stressng.validate_stressor('bogus')
+ self.assertEqual(cm.exception.code, 1)
--
2.54.0
--
Sana Sharma <sansshar@redhat.com>
reply other threads:[~2026-09-14 18:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqg4N_eb0qE3Mrbd@fedora \
--to=sansshar@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.