From: Benson Leung <bleung@google.com>
To: Jameson Thies <jthies@google.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, bleung@chromium.org,
gregkh@linuxfoundation.org, akuchynski@chromium.org
Subject: Re: [PATCH] usb: typec: ucsi: displayport: Current CAM OOB index fixup
Date: Mon, 14 Sep 2026 16:29:47 +0000 [thread overview]
Message-ID: <aqgg-5EYv3VQ4jBX@google.com> (raw)
In-Reply-To: <20260911193208.410015-1-jthies@google.com>
[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]
On Fri, Sep 11, 2026 at 07:32:08PM +0000, Jameson Thies wrote:
> Update ucsi_displayport_enter() to return invalid error when the PPM
> reports an current alternate mode greater than or equal to
> UCSI_MAX_ALTMODES. While here, remove 0xff current cam assignment on
> failed GET_CURRENT_CAM response.
>
> Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> Original patch didn't incorporate reviewer feedback. This is a fixup
> to be amended to:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=04cec690b1fd9d1c4c314b91a10d8c68a3acfe18
You should edit the commit message to use the appropriate "Fixes:" tag.
Follow the instructions here: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-changes
>
> drivers/usb/typec/ucsi/displayport.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/displayport.c b/drivers/usb/typec/ucsi/displayport.c
> index 8d2032d0762c..572da7bbd29c 100644
> --- a/drivers/usb/typec/ucsi/displayport.c
> +++ b/drivers/usb/typec/ucsi/displayport.c
> @@ -71,11 +71,14 @@ static int ucsi_displayport_enter(struct typec_altmode *alt, u32 *vdo)
> if (ret < 0) {
> if (ucsi->version > 0x0100)
> goto err_unlock;
> - cur = 0xff;
> }
>
> - if (cur < UCSI_MAX_ALTMODES) {
> - ret = dp->con->port_altmode[cur] == alt ? 0 : -EBUSY;
> + if (cur != 0xff) {
> + if (cur < UCSI_MAX_ALTMODES)
> + ret = dp->con->port_altmode[cur] == alt ? 0 : -EBUSY;
> + else
> + ret = -EINVAL;
> +
> goto err_unlock;
> }
>
>
> base-commit: ed2050bc671b44b2c948dbd4347cc534d44ccc9f
> --
> 2.55.0.1007.g17ff1f9808-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-14 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 19:32 [PATCH] usb: typec: ucsi: displayport: Current CAM OOB index fixup Jameson Thies
2026-09-14 13:14 ` Heikki Krogerus
2026-09-14 16:29 ` Benson Leung [this message]
2026-09-16 18:21 ` Greg KH
2026-09-17 2:38 ` Jameson Thies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqgg-5EYv3VQ4jBX@google.com \
--to=bleung@google.com \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.