All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: Ye Liu <ye.liu@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Ye Liu <liuye@kylinos.cn>
Subject: Re: [PATCH 1/3] mm/vmalloc: group xa_init with vbq field initializations
Date: Mon, 14 Sep 2026 18:57:14 +0200	[thread overview]
Message-ID: <aqgnahEAk7GAGi-g@milan> (raw)
In-Reply-To: <20260914-vmalloc_study-v1-1-526f68559706@linux.dev>

On Mon, Sep 14, 2026 at 11:34:00AM +0800, Ye Liu wrote:
> From: Ye Liu <liuye@kylinos.cn>
> 
> Move xa_init() next to the other vbq field initializations instead of
> after the unrelated vfree_deferred setup.
> 
> Signed-off-by: Ye Liu <liuye@kylinos.cn>
> ---
>  mm/vmalloc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 859e6d2d57a3..117483dd048c 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -5585,10 +5585,11 @@ void __init vmalloc_init(void)
>  		vbq = &per_cpu(vmap_block_queue, i);
>  		spin_lock_init(&vbq->lock);
>  		INIT_LIST_HEAD(&vbq->free);
> +		xa_init(&vbq->vmap_blocks);
> +
>  		p = &per_cpu(vfree_deferred, i);
>  		init_llist_head(&p->list);
>  		INIT_WORK(&p->wq, delayed_vfree_work);
> -		xa_init(&vbq->vmap_blocks);
>  	}
>  
>  	/*
> 
> -- 
> 2.25.1
> 
LGTM:

Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki


  reply	other threads:[~2026-09-14 16:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  3:33 [PATCH 0/3] mm/vmalloc: minor cleanups Ye Liu
2026-09-14  3:34 ` [PATCH 1/3] mm/vmalloc: group xa_init with vbq field initializations Ye Liu
2026-09-14 16:57   ` Uladzislau Rezki [this message]
2026-09-15  3:52   ` Dev Jain
2026-09-14  3:34 ` [PATCH 2/3] mm/vmalloc: extract vmap_insert_free_area helper Ye Liu
2026-09-14 17:02   ` Uladzislau Rezki
2026-09-15  2:25     ` Ye Liu
2026-09-15  3:48       ` Dev Jain
2026-09-14  3:34 ` [PATCH 3/3] mm/vmalloc: extract show_busy_info from vmalloc_info_show Ye Liu
2026-09-14 17:10   ` Uladzislau Rezki
2026-09-15  2:26     ` Ye Liu
2026-09-15  4:38     ` Andrew Morton
2026-09-15 14:55       ` Uladzislau Rezki
2026-09-15  4:23   ` Dev Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqgnahEAk7GAGi-g@milan \
    --to=urezki@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuye@kylinos.cn \
    --cc=ye.liu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.