From: Mike Rapoport <rppt@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nguyen Ngoc Thang <ngocthang2710.1999@gmail.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <liam@infradead.org>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jan Kara <jack@suse.cz>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v2] khugepaged: hold invalidate_lock across collapse_file() readahead
Date: Mon, 14 Sep 2026 19:58:12 +0300 [thread overview]
Message-ID: <aqgnpAqG_OS7gTeX@kernel.org> (raw)
In-Reply-To: <00dcd8d2-67f3-4ecd-bd7f-06ba1f9c106a@kernel.org>
On Mon, Sep 14, 2026 at 04:19:11PM +0200, David Hildenbrand (Arm) wrote:
> >
> > See https://lore.kernel.org/linux-mm/aqbtfms0_2ULBIT7@gremlin/
> >
> > I am not really entirely happy with somebody who has sent a flurry of patches
> > across disparate subsystems with no previous track record being in charge of a
> > potentially backported fix.
> >
> > It's David's decision but I think this fix should be taken over by somebody
> > else.
>
> IIUC, this patch might be responsible for random CI failures (Mike still
> investigating).
Checkout of this commit in mm-unstable [ 1be399d378b78 ("khugepaged: hold
invalidate_lock across collapse_file() readahead") as of a few hours back ]
'khugepaged all:file $XFS_DIR' fails once in 20 or so runs on my machine.
With this commit reverted, 400 iterations didn't fail.
> So I'd prefer if this is taken over by someone familiar with that code.
>
> @Willy, @Zi, @Lance?
>
>
> --
> Cheers,
>
> David
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-09-14 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 10:11 [PATCH] khugepaged: hold invalidate_lock across collapse_file() readahead Nguyen Ngoc Thang
2026-09-13 16:12 ` Lance Yang
2026-09-13 16:16 ` Lance Yang
2026-09-13 16:31 ` Zi Yan
2026-09-13 16:36 ` [PATCH v2] " Nguyen Ngoc Thang
2026-09-13 18:17 ` Andrew Morton
2026-09-13 18:48 ` Lorenzo Stoakes (ARM)
2026-09-13 18:49 ` Lorenzo Stoakes (ARM)
2026-09-14 14:19 ` David Hildenbrand (Arm)
2026-09-14 16:58 ` Mike Rapoport [this message]
2026-09-15 16:14 ` David Hildenbrand (Arm)
2026-09-13 22:34 ` Matthew Wilcox
2026-09-14 3:14 ` Baolin Wang
2026-09-13 18:43 ` [PATCH] " Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqgnpAqG_OS7gTeX@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=ngocthang2710.1999@gmail.com \
--cc=nico.pache@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=usama.arif@linux.dev \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.