From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tengda Wu <wutengda@huaweicloud.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org, Zecheng Li <zli94@ncsu.edu>,
Yanbo Zhao <yzhao62@ncsu.edu>,
Shuai Xue <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v2 1/4] perf annotate-data: Convert type histogram to hashmap
Date: Mon, 14 Sep 2026 16:22:54 -0300 [thread overview]
Message-ID: <aqhJjtWljIoMKfI_@x2> (raw)
In-Reply-To: <aqhDYxJ9qf_gE5KC@x2>
On Mon, Sep 14, 2026 at 03:56:35PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Sep 14, 2026 at 08:22:06PM +0800, Tengda Wu wrote:
> > On 2026/9/14 14:45, Namhyung Kim wrote:
> > > The type histogram maintains sample counts and periods per offset. Use
> > > a hashmap instead of an array to reduce the memory overhead.
>
> > > No functional changes intended.
> <SNIP>
> > > - struct type_hist **histograms;
> > > + struct type_hist *histograms;
> > > };
>
> > > extern struct annotated_data_type unknown_type;
>
> > Reviewed-by: Tengda Wu <wutengda@huaweicloud.com>
>
> I'm cherry picking this first patch, as I'll need to rebase my branch on
> top of it and thus testing it as I go developing it, sashiko found no
> problems and Tengda reviewed it.
It is now in tmp.perf-tools-next, will do the usual set of containerized
build tests and push,
- Arnaldo
next prev parent reply other threads:[~2026-09-14 19:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 6:45 [PATCH v2 0/4] perf annotate-data: Support flexible array types Namhyung Kim
2026-09-14 6:45 ` [PATCH v2 1/4] perf annotate-data: Convert type histogram to hashmap Namhyung Kim
2026-09-14 6:58 ` sashiko-bot
2026-09-14 12:22 ` Tengda Wu
2026-09-14 18:56 ` Arnaldo Carvalho de Melo
2026-09-14 19:22 ` Arnaldo Carvalho de Melo [this message]
2026-09-14 20:42 ` Namhyung Kim
2026-09-14 6:45 ` [PATCH v2 2/4] perf dwarf-aux: Add die_has_flex_array() helper Namhyung Kim
2026-09-14 6:53 ` sashiko-bot
2026-09-14 12:14 ` Tengda Wu
2026-09-14 20:28 ` Namhyung Kim
2026-09-14 23:40 ` Masami Hiramatsu
2026-09-15 5:54 ` Namhyung Kim
2026-09-16 13:56 ` Masami Hiramatsu
2026-09-14 6:45 ` [PATCH v2 3/4] perf annotate-date: Allow out-of-size access for flex-array types Namhyung Kim
2026-09-14 7:00 ` sashiko-bot
2026-09-14 20:32 ` Namhyung Kim
2026-09-14 12:19 ` Tengda Wu
2026-09-14 20:39 ` Namhyung Kim
2026-09-14 6:45 ` [PATCH v2 4/4] perf annotate-data: Adjust type offset for flex-array Namhyung Kim
2026-09-14 7:01 ` sashiko-bot
2026-09-14 20:38 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqhJjtWljIoMKfI_@x2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wutengda@huaweicloud.com \
--cc=xueshuai@linux.alibaba.com \
--cc=yzhao62@ncsu.edu \
--cc=zli94@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.