Re: [PATCH 07/10] ASoC: soc-dai: rename snd_soc_dai_stream_active()

["Alvin Šipraga" <alvin.sipraga@analog.com>]

Hi Kuninori,

On Mon, Sep 14, 2026 at 01:46:21AM +0000, Kuninori Morimoto wrote:
> snd_soc_dai_stream_active() (A) and snd_soc_dai_active() (B) are almost
> same function, but implemented different place with different naming.
> 
> Let's move snd_soc_dai_stream_active() (A) prev to snd_soc_dai_active()
> (B), and rename it (C).
> 
> (C)+	snd_soc_dai_active_stream()
> (B)	snd_soc_dai_active()
> 	...
> (A)-	snd_soc_dai_stream_active()

I found this rename quite confusing.

Normally I read a function like snd_soc_dai_steam_active(x, y) to mean
"is stream y of dai x active"? We also have snd_soc_dai_stream_valid()
which has similar semantics.

OTOH snd_soc_dai_active_stream() sounds like "what's the active stream
of the DAI?" (which of course doesn't make sense; could be that both or
neither are active).

I sense you're trying to "namespace" all the dai->stream[dir].active
logic under functions named snd_soc_dai_active_xxx(), which is
understandable, but don't you think the following is cleaner?

snd_soc_dai_action()          <=>   similar to snd_soc_runtime_action()
snd_soc_dai_active()          <=>   is (any) DAI stream active?
snd_soc_dai_stream_active()   <=>   is (given) DAI stream active?

BTW, maybe patches 7-9 should be one patch? It might make the review a
bit easier.

Kind regards,
Alvin