From: Zorro Lang <zlang@kernel.org>
To: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Cc: fstests@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH v3 2/6] generic/795: add missing _require_scratch check
Date: Wed, 16 Sep 2026 00:54:59 +0800 [thread overview]
Message-ID: <aql1sUTD230zrLtT@zlang-mailbox> (raw)
In-Reply-To: <20260915141745.4299-3-prabhakar.pujeri@dell.com>
On Tue, Sep 15, 2026 at 02:17:41PM +0000, Prabhakar Pujeri wrote:
> The test runs _scratch_mkfs and _scratch_mount without first requiring
> a scratch device, so it fails messily instead of skipping when no
> scratch device is configured.
>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
Thanks for consolidating the scattered patches! As mentioned in my previous
review comment, I think patches 1/6 and 2/6 can be squashed together at least.
Anyway, let me take care of squashing them upon merging. Overall, the patchset
looks good to me.
Reviewed-by: Zorro Lang <zlang@kernel.org>
> tests/generic/795 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/795 b/tests/generic/795
> index fa5474c5..4c0e7bdb 100755
> --- a/tests/generic/795
> +++ b/tests/generic/795
> @@ -27,6 +27,8 @@ _cleanup()
>
> . ./common/filter
>
> +_require_scratch
> +
> fsv_file_size=10000000
> nproc_enabler=$((4 * LOAD_FACTOR))
> nproc_reader=$((6 * LOAD_FACTOR))
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-09-15 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:17 [f2fs-dev] [PATCH v3 0/6] xfstests: add missing _require_scratch checks Prabhakar Pujeri via Linux-f2fs-devel
2026-09-15 14:17 ` Prabhakar Pujeri
2026-09-15 14:17 ` [PATCH v3 1/6] generic/590,735: add missing _require_scratch check Prabhakar Pujeri
2026-09-15 14:17 ` [PATCH v3 2/6] generic/795: " Prabhakar Pujeri
2026-09-15 16:54 ` Zorro Lang [this message]
2026-09-15 14:17 ` [f2fs-dev] [PATCH v3 3/6] f2fs/015, 016: add missing _require_scratch checks Prabhakar Pujeri via Linux-f2fs-devel
2026-09-15 14:17 ` [PATCH v3 3/6] f2fs/015,016: " Prabhakar Pujeri
2026-09-15 14:17 ` [PATCH v3 4/6] btrfs/333: require scratch before checking encoded reads Prabhakar Pujeri
2026-09-15 14:17 ` [PATCH v3 5/6] btrfs/273: add missing _require_scratch check Prabhakar Pujeri
2026-09-15 14:17 ` [PATCH v3 6/6] overlay/081: " Prabhakar Pujeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aql1sUTD230zrLtT@zlang-mailbox \
--to=zlang@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=prabhakar.pujeri@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.