From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Alexey Klimov <alexey.klimov@linaro.org>
Cc: Sam Protsenko <semen.protsenko@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
Peter Griffin <peter.griffin@linaro.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Initial support for Exynos850 SoC in ACPM clk driver
Date: Tue, 15 Sep 2026 15:21:53 +0200 [thread overview]
Message-ID: <aqlElGh5b1vUlMLT@monoceros> (raw)
In-Reply-To: <20260915-exynos850-acpm-clk-v2-0-ffad4a6b3fb1@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hello,
On Tue, Sep 15, 2026 at 12:05:42AM +0100, Alexey Klimov wrote:
> - added mod_devicetable.h as Tudor suggested, added trailer in the first
> commit;
Argh, the reasoning in that suggestion was:
you need to include linux/mod_devicetable.h for kernel_ulong_t.
(https://lore.kernel.org/all/1c41ecc9-d951-45df-b933-1934e1381663@linaro.org/).
This is wrong:
$ git grep kernel_ulong_t v7.3-rc1:include/linux/mod_devicetable.h || echo void
void
Please drop the inclusion of <linux/mod_devicetable.h> again, the only
effect of including is that you introduce a bunch of unneeded build
dependencies and I'm fighting to get rid of that file.
Also note that the driver is already using struct platform_device_id
which obviously has a member with type kernel_ulong_t. If you'd need an
additional header for kernel_ulong_t, the driver wouldn't have compiled
already before.
<linux/platform_device.h> already pulls in the definition of struct
platform_device_id and thus also kernel_ulong_t. Please rely on that or
if you want to go full iwyu include <linux/device-id/platformh.>
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-15 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 23:05 [PATCH v2 0/2] Initial support for Exynos850 SoC in ACPM clk driver Alexey Klimov
2026-09-14 23:05 ` [PATCH v2 1/2] clk: samsung: acpm: introduce driver data for SoC-specific clocks Alexey Klimov
2026-09-14 23:05 ` [PATCH v2 2/2] clk: samsung: acpm: add Exynos850 support Alexey Klimov
2026-09-14 23:31 ` sashiko-bot
2026-09-15 13:21 ` Uwe Kleine-König [this message]
2026-09-20 17:08 ` [PATCH v2 0/2] Initial support for Exynos850 SoC in ACPM clk driver Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqlElGh5b1vUlMLT@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=alexey.klimov@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=bmasney+clk@redhat.com \
--cc=bmasney@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.