All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@kernel.org>
To: Christoph Hellwig <hch@infradead.org>,
	 Anand Suveer Jain <asj@kernel.org>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
	 linux-btrfs@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: Re: [PATCH 2/5] common/sysfs: adjust function naming
Date: Tue, 15 Sep 2026 22:46:48 +0800	[thread overview]
Message-ID: <aqlXp3ySGW8VCQIk@zlang-mailbox> (raw)
In-Reply-To: <aqjsZZD4RPVK-uBn@infradead.org>

On Mon, Sep 14, 2026 at 11:57:41PM -0700, Christoph Hellwig wrote:
> On Tue, Sep 15, 2026 at 01:25:06AM +0800, Zorro Lang wrote:
> > Add the _dev_ infix to helper functions associated with
> > /sys/fs/$FSTYP/<devices> to distinguish them from upcoming
> > /sys/fs/$FSTYP/features/ related helpers.
> 
> Should these even exist as separate helper?  And if so they probably
> should have btrfs in the names?

Hmm... as far as I know, btrfs is the only filesystem that exposes this
"policy" concept under /sys/fs/$FSTYP/ (correct me if I'm wrong). I'm
not sure if this was intended to be a generic design; if not, it makes
sense to add the btrfs prefix and move it over to common/btrfs.

These helpers were originally introduced by Anand. *Anand*, what do you think?
If you agree that too, I can help to do that in next version.

Thanks,
Zorro

> 

  reply	other threads:[~2026-09-15 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 17:25 [PATCH 0/5] Refactor *_fs_sysfs_* helpers Zorro Lang
2026-09-14 17:25 ` [PATCH 1/5] fstests: consolidate _require_fs_sysfs and _require_fs_sysfs_attr Zorro Lang
2026-09-15  6:56   ` Christoph Hellwig
2026-09-15 14:33     ` Zorro Lang
2026-09-14 17:25 ` [PATCH 2/5] common/sysfs: adjust function naming Zorro Lang
2026-09-15  6:57   ` Christoph Hellwig
2026-09-15 14:46     ` Zorro Lang [this message]
2026-09-14 17:25 ` [PATCH 3/5] common/rc: add helpers for /sys/fs/$FSTYP/features/ Zorro Lang
2026-09-14 17:25 ` [PATCH 4/5] common/rc: use common helper in _require_fanotify_ioerrors for f2fs Zorro Lang
2026-09-14 17:25 ` [PATCH 5/5] fstests: replace btrfs specific helpers with common sysfs helpers Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqlXp3ySGW8VCQIk@zlang-mailbox \
    --to=zlang@kernel.org \
    --cc=asj@kernel.org \
    --cc=chao@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.