From: Johan Hovold <johan@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, cocci@inria.fr
Subject: Re: [cocci] [PATCH v2] coccinelle: api: add a checker for pm_runtime_use_autosuspend() usage
Date: Wed, 16 Sep 2026 11:21:24 +0200 [thread overview]
Message-ID: <aqpflCAorrufh1i0@hovoldconsulting.com> (raw)
In-Reply-To: <20260915064327.1377-1-joshua.crofts1@gmail.com>
On Tue, Sep 15, 2026 at 06:43:27AM +0000, Joshua Crofts wrote:
> Add a checker for ensuring that pm_runtime_dont_use_autosuspend() is
> called in a file if pm_runtime_use_autosuspend() is called and its
> devm_* counterpart isn't present.
>
> Without _dont_use_autosuspend(), removing devices causes resource leaks.
No, as I've explained repeatedly elsewhere, it does not cause any
resource leaks. [1][2]
The autosuspend setting leaks if you will, but that only matters in the
theoretical corner case of someone rebinding a different driver (which
will soon also taint the kernel).
So don't exaggerate the impact, this is essentially just a cleanup,
which is fine in itself.
> Assisted-by: LLM
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
Johan
[1] https://lore.kernel.org/all/aqpd3viN1UoZBkgL@hovoldconsulting.com/
[2] https://lore.kernel.org/linux-iio/aow51Nk-cet9qaUQ@hovoldconsulting.com/
next prev parent reply other threads:[~2026-09-16 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 6:43 [cocci] [PATCH v2] coccinelle: api: add a checker for pm_runtime_use_autosuspend() usage Joshua Crofts
2026-09-16 9:21 ` Johan Hovold [this message]
2026-09-16 9:24 ` Joshua Crofts
2026-09-16 9:25 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqpflCAorrufh1i0@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=joshua.crofts1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.