From: Catalin Marinas <catalin.marinas@arm.com>
To: Zeng Heng <zengheng@huaweicloud.com>
Cc: anshuman.khandual@arm.com, gshan@redhat.com, will@kernel.org,
suzuki.poulose@arm.com, zengheng4@huawei.com,
linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: io: Reject non-user protection in ioremap_prot()
Date: Wed, 16 Sep 2026 13:35:08 +0100 [thread overview]
Message-ID: <aqqM_NoRRePxXzOO@arm.com> (raw)
In-Reply-To: <20260911015859.71164-1-zengheng@huaweicloud.com>
On Fri, Sep 11, 2026 at 09:58:59AM +0800, Zeng Heng wrote:
> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
> index 21c8e400107c..31e67f6bd4a7 100644
> --- a/arch/arm64/include/asm/io.h
> +++ b/arch/arm64/include/asm/io.h
> @@ -272,7 +272,8 @@ static inline void __iomem *ioremap_prot(phys_addr_t phys, size_t size,
> pgprot_t prot;
> ptval_t user_prot_val = pgprot_val(user_prot);
>
> - if (WARN_ON_ONCE(!(user_prot_val & PTE_USER)))
> + /* Reject PROT_NONE and exec-only */
> + if (!(user_prot_val & PTE_USER))
> return NULL;
>
> prot = __pgprot_modify(PAGE_KERNEL, PTE_ATTRINDX_MASK,
Looks alright to me:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
It would be good to get Sashiko's finding sorted out as well
(pre-existing issue). I reckon that should go in the core code.
--
Catalin
next prev parent reply other threads:[~2026-09-16 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 1:58 [PATCH v2] arm64: io: Reject non-user protection in ioremap_prot() Zeng Heng
2026-09-11 12:25 ` Will Deacon
2026-09-16 12:35 ` Catalin Marinas [this message]
2026-09-16 12:41 ` Catalin Marinas
2026-09-18 12:28 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqqM_NoRRePxXzOO@arm.com \
--to=catalin.marinas@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=zengheng4@huawei.com \
--cc=zengheng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.