All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <me@ziyao.cc>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Yao Zi <me@ziyao.cc>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1] net: stmmac: Default DWMAC_MOTORCOMM to m on MACH_LOONGSON64
Date: Wed, 16 Sep 2026 16:49:38 +0000	[thread overview]
Message-ID: <aqrIoiKSN1kMPT0f@pie> (raw)
In-Reply-To: <20260915073206.6665-1-yangtiezhu@loongson.cn>

On Tue, Sep 15, 2026 at 03:32:06PM +0800, Tiezhu Yang wrote:
> Currently, there is no network connectivity when upgrading to the
> latest upstream mainline kernel on certain Loongson machines such
> as Loongson-3C6000 server, because the driver for the onboard NIC
> is not enabled.
> 
> Enable the Motorcomm PCI DWMAC driver as a module by default when
> building for the Loongson-64 platform.
> 
> This ensures out-of-the-box support for Motorcomm YT6801 Ethernet
> controllers on Loongson machines, enabling demand-loading without
> increasing the core kernel image size.

YT6801 isn't a Loongson-specific peripheral, it's already shipped in
many other PCIe addon cards, and some x86 laptops iirc, thus it just
seems wrong to do this in the driver's Kconfig entry. I would NAK this
patch.

> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Best regards,
Yao Zi

  reply	other threads:[~2026-09-16 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  7:32 [PATCH net-next v1] net: stmmac: Default DWMAC_MOTORCOMM to m on MACH_LOONGSON64 Tiezhu Yang
2026-09-16 16:49 ` Yao Zi [this message]
2026-09-16 16:54 ` Maxime Chevallier
2026-09-17  1:01   ` Tiezhu Yang
2026-09-17 14:45     ` Andrew Lunn
2026-09-18  6:48       ` Tiezhu Yang
2026-09-18  7:10         ` Yao Zi
2026-09-18 11:53         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqrIoiKSN1kMPT0f@pie \
    --to=me@ziyao.cc \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.