All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, maz@kernel.org,
	will@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, steven.price@arm.com,
	aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com,
	joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com,
	linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com,
	sdonthineni@nvidia.com, alpergun@google.com,
	fj0570is@fujitsu.com, WeiLin.Chang@arm.com,
	lpieralisi@kernel.org, enju.kohei@fujitsu.com
Subject: Re: [PATCH v18] arm64: mm: Handle Granule Protection Faults (GPFs)
Date: Wed, 16 Sep 2026 17:56:30 +0100	[thread overview]
Message-ID: <aqrKPkMPeHdtCVGg@arm.com> (raw)
In-Reply-To: <aqrGPK0lFBFXL2qY@arm.com>

On Wed, Sep 16, 2026 at 05:39:31PM +0100, Catalin Marinas wrote:
> On Sun, Sep 13, 2026 at 08:04:58AM +0100, Suzuki K Poulose wrote:
> > +static int do_gpf(unsigned long far, unsigned long esr, struct pt_regs *regs)
> > +{
> > +	if (!user_mode(regs) && !is_el1_instruction_abort(esr) &&
> > +	    fixup_exception(regs, esr))
> > +		return 0;
> > +
> > +	return 1;
> > +}
> 
> We discussed briefly offline. With the latest patches around, would we
> ever end up with private memory mapped in the VMM and hence the GPF? If
> not, I would still keep this handling but add a
> WARN_ON_ONCE(user_mode(regs)).

Actually, even better:

	WARN_ON_ONCE(is_ttbr0_addr(untagged_addr(far)));

to capture uaccess. The user_mode() test you have above can stay the
same.

-- 
Catalin

  reply	other threads:[~2026-09-16 16:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13  7:04 [PATCH v18] arm64: mm: Handle Granule Protection Faults (GPFs) Suzuki K Poulose
2026-09-16 16:39 ` Catalin Marinas
2026-09-16 16:56   ` Catalin Marinas [this message]
2026-09-17  7:58   ` Catalin Marinas
2026-09-17  9:03   ` Suzuki K Poulose
2026-09-17 10:36     ` Catalin Marinas
2026-09-22  8:16       ` Suzuki K Poulose
2026-09-22 13:21       ` Suzuki K Poulose
2026-09-22 14:49         ` Catalin Marinas
2026-09-22 15:14           ` Suzuki K Poulose
2026-09-28 11:01           ` Suzuki K Poulose
2026-09-29 10:40             ` Catalin Marinas
2026-09-29 10:47               ` Suzuki K Poulose
2026-09-22 17:15 ` Will Deacon
2026-09-23 11:06   ` Catalin Marinas
2026-09-23 15:45     ` Will Deacon
2026-09-23 16:04       ` Suzuki K Poulose
2026-09-24 15:43         ` Catalin Marinas
2026-09-25 17:07         ` Catalin Marinas
2026-09-28 10:38           ` Suzuki K Poulose
2026-09-29 10:30             ` Catalin Marinas
2026-09-29 10:42               ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqrKPkMPeHdtCVGg@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=WeiLin.Chang@arm.com \
    --cc=alpergun@google.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=enju.kohei@fujitsu.com \
    --cc=fj0570is@fujitsu.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=gshan@redhat.com \
    --cc=joey.gouly@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=sdonthineni@nvidia.com \
    --cc=steven.price@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.