All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,
	Aleksandr Makarov <aleksandr.o.makarov@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/cpp-httplib: depends on BR2_TOOLCHAIN_HAS_SYNC_1
Date: Wed, 16 Sep 2026 23:46:49 +0200	[thread overview]
Message-ID: <aqsN2c5Z4hDxTToj@windsurf> (raw)
In-Reply-To: <20260620070343.86834-1-bernd@kuhls.net>

On Sat, Jun 20, 2026 at 09:03:43AM +0200, Bernd Kuhls wrote:
> Buildroot commit 8dad17ea06260ef0bd23eebc47c95a8510310bf5 bumped the
> package from 0.27.0 to 0.37.2. This bump includes upstream commit
> https://github.com/yhirose/cpp-httplib/commit/464867a9cedef2b6185e25e3e912d3f796fe58fd
> which added WebSocket support to version 0.33.0 and causes a build error
> detected by the Gitlab pipelines for bootlin-sparc-uclibc:
> 
> /builds/bkuhls/buildroot/br-test-pkg/bootlin-sparc-uclibc/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/14.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld:
>  /tmp/cciyXsAR.ltrans6.ltrans.o: in function
>  `httplib::ws::WebSocket::close(httplib::ws::CloseStatus,
>  std::__cxx11::basic_string<char, std::char_traits<char>,
>  std::allocator<char> > const&)':
> <artificial>:(.text+0x6408): undefined reference to `__atomic_exchange_1'

Thanks for the patch. However, I believe you're making a confusion
between __sync builtins
(https://gcc.gnu.org/onlinedocs/gcc/_005f_005fsync-Builtins.html) and
__atomic builtins
(https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html).

__sync builtins are in Buildroot covered by the
BR2_TOOLCHAIN_HAS_SYNC_xyz options.

On the other hand, __atomic built-ins are covered by
BR2_TOOLCHAIN_HAS_ATOMIC and BR2_TOOLCHAIN_HAS_LIBATOMIC.

So what you want to do here is:

1. Add depends on BR2_TOOLCHAIN_HAS_ATOMIC in Config.in

2. Ensure that the code is linked against libatomic if
   BR2_TOOLCHAIN_HAS_LIBATOMIC

Could you have a look into this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-09-16 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-20  7:03 [Buildroot] [PATCH 1/1] package/cpp-httplib: depends on BR2_TOOLCHAIN_HAS_SYNC_1 Bernd Kuhls
2026-09-16 21:46 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqsN2c5Z4hDxTToj@windsurf \
    --to=buildroot@buildroot.org \
    --cc=aleksandr.o.makarov@gmail.com \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.