From: Dan Carpenter <error27@gmail.com>
To: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: return bool from check_pending_xmitbuf
Date: Thu, 1 Oct 2026 13:39:28 +0300 [thread overview]
Message-ID: <ar44YIe8blCkSHCP@stanley.mountain> (raw)
In-Reply-To: <20261001100441.102765-1-matheus.aalmeida@inf.ufrgs.br>
On Thu, Oct 01, 2026 at 07:04:41AM -0300, Matheus Alves de Almeida wrote:
> @@ -2482,7 +2482,7 @@ signed int check_pending_xmitbuf(struct xmit_priv *pxmitpriv)
>
> int rtw_xmit_thread(void *context)
> {
> - s32 err;
> + bool err;
err should never be bool in the kernel. It should be int or ssize_t.
Same thing for ret ideally. Pick a better name or people will think
"ret" is a normal "ret".
> struct adapter *padapter;
>
> err = _SUCCESS;
^^^^^^^^^^^^^^
regards,
dan carpenter
prev parent reply other threads:[~2026-10-01 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 10:04 [PATCH v3] staging: rtl8723bs: return bool from check_pending_xmitbuf Matheus Alves de Almeida
2026-10-01 10:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar44YIe8blCkSHCP@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matheus.aalmeida@inf.ufrgs.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.