All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Elson Serrao <elson.serrao@oss.qualcomm.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] usb: dwc3: Clear SUSPHY before issuing core soft reset
Date: Fri, 2 Oct 2026 00:48:23 +0000	[thread overview]
Message-ID: <ar7-H4Q9U3sNou0Q@vbox> (raw)
In-Reply-To: <20261002000741.450793-2-elson.serrao@oss.qualcomm.com>

On Thu, Oct 01, 2026, Elson Serrao wrote:
> The controller clears DCTL.CSFTRST only after all required logic has
> been reset and all PHY clocks are active. If SUSPHY remains set, the PHY
> may not be fully active during the reset sequence, causing the core soft
> reset to fail to complete.
>  
> Clear SUSPHY before asserting DCTL.CSFTRST to ensure the PHY remains
> active while the reset is in progress.
> 
> Fixes: cc5bfc4e16fc ("usb: dwc3: Set SUSPENDENABLE soon after phy init")
> Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
> ---
>  drivers/usb/dwc3/core.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index fd5c2cd36c59..282a853c364e 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -332,6 +332,13 @@ int dwc3_core_soft_reset(struct dwc3 *dwc)
>  	if (dwc->current_dr_role == DWC3_GCTL_PRTCAP_HOST)
>  		return 0;
>  
> +	/*
> +	 * The core clears DCTL.CSFTRST only after all necessary logic is
> +	 * reset and all PHY clocks are active/running. Clear SUSPHY before
> +	 * issuing the reset so that the PHY is active.
> +	 */
> +	dwc3_enable_susphy(dwc, false);
> +
>  	reg = dwc3_readl(dwc, DWC3_DCTL);
>  	reg |= DWC3_DCTL_CSFTRST;
>  	reg &= ~DWC3_DCTL_RUN_STOP;
> -- 
> 2.34.1
> 

Most platforms require SUSPHY to be set before soft reset. Can you
handle this via a pre_soft_reset() glue_ops for the affected platform
instead?

Thanks,
Thinh

  reply	other threads:[~2026-10-02  0:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  0:07 [RFC PATCH 0/1] usb: dwc3: Clear SUSPHY before issuing core soft reset Elson Serrao
2026-10-02  0:07 ` [RFC PATCH 1/1] " Elson Serrao
2026-10-02  0:48   ` Thinh Nguyen [this message]
2026-10-08  0:06     ` Elson Serrao
2026-10-08  1:57       ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar7-H4Q9U3sNou0Q@vbox \
    --to=thinh.nguyen@synopsys.com \
    --cc=elson.serrao@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.