From: Sean Christopherson <seanjc@google.com>
To: Leonardo Bras <leo.bras@arm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
David Matlack <dmatlack@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Marc Zyngier <maz@kernel.org>, Josh Hilke <jrhilke@google.com>,
Oliver Upton <oupton@kernel.org>,
Wu Fei <wu.fei9@sanechips.com.cn>,
Steffen Eiden <seiden@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] KVM: selftests: Check dirty-ring size before enabling
Date: Thu, 1 Oct 2026 16:18:35 -0700 [thread overview]
Message-ID: <ar7qS3PeV_zo93iT@google.com> (raw)
In-Reply-To: <ar5yW30S75THCfdV@LeoBrasDK>
On Thu, Oct 01, 2026, Leonardo Bras wrote:
> On Wed, Sep 30, 2026 at 01:31:25PM -0700, Sean Christopherson wrote:
> > > "Dirty-ring not supported in this kernel\n");
> >
> > "this kernel" could be misleading, some architectures simply don't support the
> > dirty ring.
Hmm, the counter argument is that this is actually accurate if those architectures
were to gain support in the future, but someone ran this on an older kernel...
> So, do you suggest keeping it simple by printing "Dirty-ring not supported"?
Yeah, unless you have a better idea. Actually, even though Kconfig isn't user-
controllable, it's still there in the .config. So maybe something like this?
TEST_ASSERT(cap, "Dirty-ring not supported, check CONFIG_HAVE_KVM_DIRTY_RING?");
That would at least give the user a breadcrumb to start with.
next prev parent reply other threads:[~2026-10-01 23:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 11:37 [PATCH v1 0/3] KVM: selftests: Add support for dirty-ring on dirty_log_perf_test Leonardo Bras
2026-09-29 11:37 ` [PATCH v1 1/3] KVM: selftests: memstress: Add option to enable dirty-ring on VM creation Leonardo Bras
2026-09-30 18:21 ` Sean Christopherson
2026-10-01 14:40 ` Leonardo Bras
2026-09-29 11:37 ` [PATCH v1 2/3] KVM: selftests: Check dirty-ring size before enabling Leonardo Bras
2026-09-30 20:31 ` Sean Christopherson
2026-10-01 14:46 ` Leonardo Bras
2026-10-01 17:02 ` Leonardo Bras
2026-10-01 21:56 ` Sean Christopherson
2026-10-02 11:14 ` Leonardo Bras
2026-10-01 23:18 ` Sean Christopherson [this message]
2026-10-02 11:14 ` Leonardo Bras
2026-09-29 11:37 ` [PATCH v1 3/3] KVM: selftests: dirty_log_perf_test: Add dirty-ring support Leonardo Bras
2026-09-29 11:53 ` sashiko-bot
2026-09-29 14:13 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar7qS3PeV_zo93iT@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=dmatlack@google.com \
--cc=imbrenda@linux.ibm.com \
--cc=jrhilke@google.com \
--cc=kvm@vger.kernel.org \
--cc=leo.bras@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=seiden@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=wu.fei9@sanechips.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.