From: Dan Carpenter <error27@gmail.com>
To: Adi Prasan <itsadi2409@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix ie_length bound check in rtw_cfg80211_inform_bss
Date: Fri, 2 Oct 2026 10:25:05 +0300 [thread overview]
Message-ID: <ar9cUQd-NEJozKxg@stanley.mountain> (raw)
In-Reply-To: <CAAd6oEjAMrJjx6PLDE7jj5OsgbwFWU9Uoy=_UyO8w-5AyZCxqw@mail.gmail.com>
On Thu, Oct 01, 2026 at 10:51:00PM +0530, Adi Prasan wrote:
> Sorry for the late reply.
> On where ie_length gets set - there's three places: collect_bss_info() in
> rtw_mlme_ext.c, and the two H2C_PARAMETERS_ERROR checks further down in the
> same file. All three cap it to MAX_IE_SZ before it's ever assigned, so it
> can't actually go out of bounds.
>
> On a more sensible limit instead of MAX_BSSINFO_LEN.what do you have in
> mind?
Please don't top post.
Why not use MAX_IE_SZ as the limit?
regards,
dan carpenter
next prev parent reply other threads:[~2026-10-02 7:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 14:28 [PATCH] staging: rtl8723bs: fix ie_length bound check in rtw_cfg80211_inform_bss Adi Prasan
2026-09-20 15:37 ` Greg KH
2026-09-21 5:13 ` Adi Prasan
2026-09-21 15:23 ` Dan Carpenter
2026-09-21 17:03 ` Adi Prasan
2026-09-22 7:48 ` Dan Carpenter
2026-09-21 16:55 ` [PATCH v2] " Adi Prasan
2026-09-22 10:22 ` Dan Carpenter
[not found] ` <CAAd6oEjAMrJjx6PLDE7jj5OsgbwFWU9Uoy=_UyO8w-5AyZCxqw@mail.gmail.com>
2026-10-02 7:25 ` Dan Carpenter [this message]
2026-10-02 14:06 ` [PATCH] " Adi Prasan
2026-10-02 14:04 ` [PATCH v3] " Adi Prasan
2026-10-02 14:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar9cUQd-NEJozKxg@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=itsadi2409@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.