Re: [PATCH v1 0/2] Enable PCIe WAKE# as a system wake source on Tegra234

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2546 bytes --]

On Mon, Sep 07, 2026 at 05:01:32PM +0530, Manikanta Maddireddy wrote:
> The P3768 carrier board used by Jetson Orin NX and Orin Nano routes the
> PCIe WAKE# signal to Tegra234 main GPIO L.2. Nothing in the kernel
> currently describes that signal, so a suspended system cannot be woken
> by a PCIe endpoint.
> 
> This series wires it up in two steps.
> 
> Patch 1 adds the PMC wake event mapping for GPIO L.2. This is the piece
> that lets the GPIO interrupt be armed as a system wake source during
> suspend, rather than being treated as an ordinary interrupt that is
> masked along with the rest of the GPIO controller.
> 
> Patch 2 describes the signal in device tree, on the root port of the C8
> controller. C8 is the controller with the onboard Ethernet NIC on this
> carrier, so describing WAKE# there is what makes wake-on-LAN usable.
> The property is consumed by the generic PCI core in
> pci_configure_of_wake_gpio(), which looks it up on the OF node of the
> PCI device itself, so no controller driver change is needed.
> 
> The two patches touch different subsystems but are only useful together,
> so they are posted as one series. Patch 2 depends on patch 1 to have any
> effect.
> 
> Testing:
> 
>   - Verification:
>     - Verified suspend-to-RAM functionality with no spurious pending
>       wake sources observed.
>     - Verified wake up through GPIO L.2 using an Ethernet magic packet.
>     - Verified the reported wake source after resume.
>     - Verified that regular Ethernet traffic does not trigger an
>       unintended wake-up.
>     - Confirmed Ethernet connectivity and normal network operation
>       after resume.
>     - Repeated multiple suspend/resume cycles to verify consistent
>       behavior.
>   - make ARCH=arm64 CHECK_DTBS=y is clean for the two affected boards,
>     tegra234-p3768-0000+p3767-0000 and -0005, with dtschema 2026.6.
>   - checkpatch --strict reports no issues on either patch.
> 
> Note: the series is based on the linux-next 20260817 snapshot rather
> than a maintainer tree; see the base-commit trailer below. Happy to
> rebase onto whichever tree you prefer.
> 
> Manikanta Maddireddy (2):
>   soc/tegra: pmc: Add PCIe wake event for Tegra234
>   arm64: tegra: Add PCIe wake GPIO for Jetson Orin NX/Nano
> 
>  .../boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi     | 10 ++++++++++
>  drivers/soc/tegra/pmc.c                                |  1 +
>  2 files changed, 11 insertions(+)

Both patches applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]