Re: [PATCH] chtls: Fix skb reference leak in chtls_send_reset()

[Sabrina Dubroca <sd@queasysnail.net>]

2026-09-19, 09:04:28 +0100, Simon Horman wrote:
> > diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
> > index 0e3e5cf52c2c..a363f20452fa 100644
> > --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
> > +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
> > @@ -265,12 +265,14 @@ static void chtls_send_reset(struct sock *sk, int mode, struct sk_buff *skb)
> >  	chtls_purge_write_queue(sk);
> >  
> >  	csk_set_flag(csk, CSK_ABORT_SHUTDOWN);
> > -	if (sk->sk_state != TCP_SYN_RECV)
> > +	if (sk->sk_state != TCP_SYN_RECV) {
> >  		chtls_send_abort(sk, mode, skb);
> > -	else
> > +	} else {
> >  		chtls_set_tcb_field_rpl_skb(sk, TCB_T_FLAGS_W,
> >  					    TCB_T_FLAGS_V(TCB_T_FLAGS_M), 0,
> >  					    TCB_FIELD_COOKIE_TFLAG, 1);
> > +		kfree_skb(skb);
> > +	}
> >  
> >  	return;
> >  out:
> 
> This code change looks reasonable to me.
> But the driver was removed in v7.2 by
> cdae65fc43f2 ("tls: remove tls_toe and the related driver")
> And, as a result it didn't run through our CI.
> 
> So while I think it could go to stable
> It probably needs more eyes on it.

But there isn't anyone around that has even a remote understanding of
what this driver does... Since stable@ seems willing to take patches
that remove broken features [1], maybe we should just do that?

[1] https://lore.kernel.org/netdev/apbqjuv6l20bTjQI@laps/

-- 
Sabrina