From: Catalin Marinas <catalin.marinas@arm.com>
To: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org>
Cc: linux-coco@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
Greg KH <gregkh@linuxfoundation.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <will@kernel.org>,
Steven Price <steven.price@arm.com>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH v12 3/7] firmware: arm_rmm: Move RSI support out of arch/arm64
Date: Mon, 21 Sep 2026 09:50:06 +0100 [thread overview]
Message-ID: <arDvvvqkm0O4OSlP@arm.com> (raw)
In-Reply-To: <20260921053807.354802-4-aneesh.kumar@kernel.org>
On Mon, Sep 21, 2026 at 11:08:03AM +0530, Aneesh Kumar K.V (Arm) wrote:
> The RSI SMCCC function IDs describe a firmware ABI and are not arm64
> architecture specific definitions. Follow-up changes need to use them from
> non-arch code, including drivers/firmware/smccc and the Arm CCA guest
> driver.
>
> Move the complete Realm Service Interface (RSI) implementation from
> arch/arm64 to drivers/firmware/arm_rmm. The RSI SMCCC definitions and
> command helpers are also moved to include/linux so they can be shared by
> architecture code and firmware or driver code. This also keeps the
> firmware interface outside architecture code, as requested [1].
>
> [1] https://lore.kernel.org/all/agsNO9cc7H-b0H8L@willie-the-truck
>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>
> ---
> MAINTAINERS | 2 +
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/io.h | 2 +-
> arch/arm64/include/asm/mem_encrypt.h | 2 +-
> arch/arm64/include/asm/pgtable-prot.h | 2 +-
> arch/arm64/include/asm/rsi.h | 70 -----------------
> arch/arm64/kernel/Makefile | 2 +-
> arch/arm64/kernel/setup.c | 2 +-
> arch/arm64/mm/init.c | 3 +-
> drivers/firmware/Kconfig | 1 +
> drivers/firmware/Makefile | 1 +
> drivers/firmware/arm_rmm/Kconfig | 17 ++++
> drivers/firmware/arm_rmm/Makefile | 2 +
> .../kernel => drivers/firmware/arm_rmm}/rsi.c | 2 +-
> drivers/virt/coco/arm-cca-guest/Kconfig | 2 +-
> .../virt/coco/arm-cca-guest/arm-cca-guest.c | 5 +-
> .../linux/arm-rsi-cmds.h | 77 +++++++++++++++++--
> .../linux/arm-smccc-rsi.h | 6 +-
> 18 files changed, 110 insertions(+), 89 deletions(-)
> delete mode 100644 arch/arm64/include/asm/rsi.h
> create mode 100644 drivers/firmware/arm_rmm/Kconfig
> create mode 100644 drivers/firmware/arm_rmm/Makefile
> rename {arch/arm64/kernel => drivers/firmware/arm_rmm}/rsi.c (99%)
> rename arch/arm64/include/asm/rsi_cmds.h => include/linux/arm-rsi-cmds.h (69%)
> rename arch/arm64/include/asm/rsi_smc.h => include/linux/arm-smccc-rsi.h (98%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42364c540f50..b867d537a579 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3953,6 +3953,8 @@ F: Documentation/arch/arm64/
> F: arch/arm64/
> F: drivers/virt/coco/arm-cca-guest/
> F: drivers/virt/coco/pkvm-guest/
> +F: include/linux/arm-rsi-cmds.h
> +F: include/linux/arm-smccc-rsi.h
> F: tools/testing/selftests/arm64/
> X: arch/arm64/boot/dts/
> X: arch/arm64/configs/defconfig
Does it need drivers/firmware/arm_rmm/ as well?
--
Catalin
next prev parent reply other threads:[~2026-09-21 8:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 5:38 [PATCH v12 0/7] Switch Arm SMCCC firmware services to an SMCCC bus Aneesh Kumar K.V (Arm)
2026-09-21 5:38 ` [PATCH v12 1/7] firmware: smccc: Add an Arm " Aneesh Kumar K.V (Arm)
2026-09-21 8:39 ` Catalin Marinas
2026-09-21 9:03 ` Aneesh Kumar K.V
2026-09-21 5:38 ` [PATCH v12 2/7] firmware: hwrng: arm_smccc_trng: Register as an SMCCC device Aneesh Kumar K.V (Arm)
2026-09-21 8:45 ` Catalin Marinas
2026-09-21 9:01 ` Aneesh Kumar K.V
2026-09-21 5:38 ` [PATCH v12 3/7] firmware: arm_rmm: Move RSI support out of arch/arm64 Aneesh Kumar K.V (Arm)
2026-09-21 8:50 ` Catalin Marinas [this message]
2026-09-21 5:38 ` [PATCH v12 4/7] arm64: realm: Move Realm memory encryption ops to RSI code Aneesh Kumar K.V (Arm)
2026-09-21 8:52 ` Catalin Marinas
2026-09-21 9:05 ` Aneesh Kumar K.V
2026-09-21 10:00 ` Suzuki K Poulose
2026-09-21 22:24 ` Jonathan Cameron
2026-09-21 5:38 ` [PATCH v12 5/7] virt: coco: arm-cca-guest: Rename TSM report source file Aneesh Kumar K.V (Arm)
2026-09-21 22:25 ` Jonathan Cameron
2026-09-21 5:38 ` [PATCH v12 6/7] firmware: smccc: arm-cca-guest: Bind the TSM provider to an SMCCC device Aneesh Kumar K.V (Arm)
2026-09-21 5:38 ` [PATCH v12 7/7] coco: guest: arm64: Replace dummy CCA device with sysfs ABI Aneesh Kumar K.V (Arm)
2026-09-21 9:00 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arDvvvqkm0O4OSlP@arm.com \
--to=catalin.marinas@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=andre.przywara@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=jgg@nvidia.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.