From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23A22C982E1 for ; Mon, 21 Sep 2026 14:20:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x8es0-0006hf-As; Mon, 21 Sep 2026 10:19:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x8err-0006dj-IC for qemu-devel@nongnu.org; Mon, 21 Sep 2026 10:19:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x8ern-0007O6-N5 for qemu-devel@nongnu.org; Mon, 21 Sep 2026 10:19:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790000374; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WpneFY3lkYdMhydebwCMWa7Bm/mBweRqZ3DjbGiiETs=; b=LY1c07z5drItoxLtsI7s+nwr9GjGaUUCzC8CkNQc0soYOmxrFQTGPjSeJVkNoaPd+v4DAJ tasemaFD9lRpiqO5xc0mmP+NmniGXgB1B1kuB7sTJQVqQDmtcFiHqB8ghNWywYZzyT1T7m 9nM63zyDosNiAEtgApBYjI4HCL3+/Hc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-BrfTrANDOqG3Hz8LpxEmqA-1; Mon, 21 Sep 2026 10:19:30 -0400 X-MC-Unique: BrfTrANDOqG3Hz8LpxEmqA-1 X-Mimecast-MFC-AGG-ID: BrfTrANDOqG3Hz8LpxEmqA_1790000368 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D908184B393; Mon, 21 Sep 2026 14:19:26 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 810D319539A7; Mon, 21 Sep 2026 14:19:19 +0000 (UTC) Date: Mon, 21 Sep 2026 15:19:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Cc: qemu-devel@nongnu.org, Xianglai Li , Weiwei Li , Alistair Francis , Stafford Horne , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Jiaxun Yang , Zhao Liu , Brian Cain , Laurent Vivier , Peter Maydell , Pierrick Bouvier , Paolo Bonzini , Song Gao <17746591750@163.com>, Daniel Henrique Barboza , Bibo Mao , Chao Liu , Palmer Dabbelt , Philippe Mathieu-Daude , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Liu Zhiwei , Max Filippov Subject: Re: [PATCH 1/8] machine: allow -M name to differ from QOM type Message-ID: References: <20260918000640.1001-1-luoyonggang@gmail.com> <20260918000640.1001-2-luoyonggang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260918000640.1001-2-luoyonggang@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 18, 2026 at 08:06:32AM +0800, Yonggang Luo wrote: > - Add machine_class_set_name() so boards can keep a stable -M name > when the QOM type is uniquified. machine_class_base_init still > defaults the name to the QOM type without -machine. > - Document that MachineClass::name is the -M name, not the QOM type. > - Sort -M help by MachineClass::name so order matches the printed names > when QOM types are prefixed (arm-virt-11.1-machine vs virt-11.1). > > Signed-off-by: Yonggang Luo > --- > hw/core/machine.c | 6 ++++++ > include/hw/core/boards.h | 12 +++++++++++- > system/vl.c | 8 +++----- > 3 files changed, 20 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|