From: Mark Brown <broonie@kernel.org>
To: "Xu, Baojun" <baojun.xu@ti.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Yi, Ken" <k-yi@ti.com>, "Lo, Henry" <henry.lo@ti.com>,
"Chen, Robin" <robinchen@ti.com>,
"Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>,
"pin-hao.huang@hp.com" <pin-hao.huang@hp.com>,
"Syed.SabaKareem@amd.com" <Syed.SabaKareem@amd.com>
Subject: Re: [EXTERNAL] Re: [PATCH v5] ASoC: tas2783-sdw: add firmware download status check
Date: Mon, 21 Sep 2026 12:14:49 +0200 [thread overview]
Message-ID: <arEDmZ76qb3eLiwk@sirena.co.uk> (raw)
In-Reply-To: <4d1f121c8ac348dcbb16b554e4ed2b9c@ti.com>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On Mon, Sep 21, 2026 at 10:08:54AM +0000, Xu, Baojun wrote:
> Previously, a local variable tracked the AMP reset state to determine if a
> firmware download was required. However, we observed that the AMP resets
> during SoundWire bus stop/start sequences, causing the variable to become
> stale. To improve stability, the driver now directly reads the register
> value instead of relying on the cached variable.
It should just need an assignment to set the download flag when you
decide to skip?
> This version has been verified to work correctly on the current platform.
Are you sure there are no users with other systems who might be broken
by skipping the download?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-09-21 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 6:40 [PATCH v5] ASoC: tas2783-sdw: add firmware download status check Baojun Xu
2026-09-21 8:45 ` Mark Brown
2026-09-21 9:22 ` [EXTERNAL] " Xu, Baojun
2026-09-21 9:27 ` Mark Brown
2026-09-21 10:08 ` Xu, Baojun
2026-09-21 10:14 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arEDmZ76qb3eLiwk@sirena.co.uk \
--to=broonie@kernel.org \
--cc=13916275206@139.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=henry.lo@ti.com \
--cc=k-yi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=pin-hao.huang@hp.com \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.