Re: [PULL 2/7] hw/isa/pc87560: Add main isa code for NS 87560 SuperIO chip

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Sep 21, 2026 at 11:51:43AM +0200, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> On 18/9/26 18:38, Helge Deller wrote:
> > From: Abizer Lokhandwala <abizerlokhandwalastd10@gmail.com>
> > 
> > Add emulation of the core components (PCI function 1 aka I/O
> > Peripherals) of the National Semiconductor SuperIO chip which was
> > commonly used in HP PA-RISC B- and C-class workstations. This includes
> > the PIC interrupt controller, the floppy controller, serial and parallel
> > ports.
> > 
> > Signed-off-by: Abizer Lokhandwala <abizerlokhandwalastd10@gmail.com>
> > Signed-off-by: Helge Deller <deller@gmx.de>
> > ---
> >   MAINTAINERS              |   2 +
> >   hw/isa/Kconfig           |  11 +
> >   hw/isa/pc87560.c         | 510 +++++++++++++++++++++++++++++++++++++++
> >   include/hw/isa/pc87560.h |  96 ++++++++
> >   4 files changed, 619 insertions(+)
> >   create mode 100644 hw/isa/pc87560.c
> >   create mode 100644 include/hw/isa/pc87560.h
> 
> 
> > diff --git a/hw/isa/pc87560.c b/hw/isa/pc87560.c
> > new file mode 100644
> > index 0000000000..c13c54deb2
> > --- /dev/null
> > +++ b/hw/isa/pc87560.c
> > @@ -0,0 +1,510 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> 
> Did we change the coding style to allow C++ comments?

We've got a bit of historical cruft using "//" with SPDX-License-Identifier
that might mislead people who are cribbing existnig code, but yes, we
should prefer '/* .... */' comments in C files.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|