From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Cc: pbonzini@redhat.com, richard.henderson@linaro.org,
mst@redhat.com, mtosatti@redhat.com, marcandre.lureau@redhat.com,
armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 1/9] qom/object.c: improve duplicate class property detection assert()
Date: Mon, 21 Sep 2026 13:14:36 +0100 [thread overview]
Message-ID: <arEfrCOap5itk3d1@redhat.com> (raw)
In-Reply-To: <20260921113559.1299740-2-mark.caveayland@nutanix.com>
On Mon, Sep 21, 2026 at 12:35:07PM +0100, Mark Cave-Ayland wrote:
> Introduce an intermediary boolean prop_already_exists into object_class_property_add()
> so that it is obvious to a developer if they inadvertantly introduce a duplicate
> class property:
>
> qemu-system-x86_64: ../qom/object.c:1417: object_class_property_add:
> Assertion `!prop_already_exists' failed.
>
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
> qom/object.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-09-21 12:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 11:35 [PATCH v4 0/9] hw/i386: convert object props to class props Mark Cave-Ayland
2026-09-21 11:35 ` [PATCH v4 1/9] qom/object.c: improve duplicate class property detection assert() Mark Cave-Ayland
2026-09-21 12:14 ` Daniel P. Berrangé [this message]
2026-09-21 11:35 ` [PATCH v4 2/9] qom/object.c: introduce object_alias_get_targetp() lookup function Mark Cave-Ayland
2026-09-21 12:17 ` Daniel P. Berrangé
2026-09-21 11:35 ` [PATCH v4 3/9] qom/object.c: introduce object_class_property_add_alias() Mark Cave-Ayland
2026-09-21 12:21 ` Daniel P. Berrangé
2026-09-21 11:35 ` [PATCH v4 4/9] qom/object.c: introduce object_property_set_alias() function Mark Cave-Ayland
2026-09-21 12:28 ` Daniel P. Berrangé
2026-09-21 11:35 ` [PATCH v4 5/9] hw/i386/pc.c: convert pcspk-audiodev object prop to a class prop Mark Cave-Ayland
2026-09-21 11:35 ` [PATCH v4 6/9] hw/i386/pc.c: convert rtc-time " Mark Cave-Ayland
2026-09-21 11:35 ` [PATCH v4 7/9] hw/i386/pc.c: convert PC_MACHINE_ACPI_DEVICE_PROP from object prop to " Mark Cave-Ayland
2026-09-21 11:35 ` [PATCH v4 8/9] hw/i386/pc_sysfw.c: convert pflash0 and pflash1 object props to class props Mark Cave-Ayland
2026-09-21 11:35 ` [PATCH v4 9/9] hw/i386/sgx-epc.c: convert SGX_EPC_SIZE_PROP object prop to class prop Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arEfrCOap5itk3d1@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.caveayland@nutanix.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.