From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F934C982ED for ; Mon, 21 Sep 2026 12:21:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x8d1i-0001rl-3I; Mon, 21 Sep 2026 08:21:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x8d1W-0001rG-SD for qemu-devel@nongnu.org; Mon, 21 Sep 2026 08:21:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x8d1T-0000YG-8V for qemu-devel@nongnu.org; Mon, 21 Sep 2026 08:21:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789993286; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b+0zBcLjirbPh00o9HYPxA/kZbVHtgTIrru/umcpedY=; b=evrgHlGAmBRBEhr7qc2TASZ7SaRjm92dG6DjdF2aWh2pznYxlBQU7/8b3JcjMj/DiF0btq c+OhfUSBcfi8EFtDWnT+GQ0GyS6ntsfrdyCFuUhfWCOpGVEEWbA4a8VMUpfkt+bV60nARB 2h8+dHHA3x9BrJr+NnG3ZyeJlDV2Dqs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-9IBjJBqrNdy1t0VxwSN7bQ-1; Mon, 21 Sep 2026 08:21:22 -0400 X-MC-Unique: 9IBjJBqrNdy1t0VxwSN7bQ-1 X-Mimecast-MFC-AGG-ID: 9IBjJBqrNdy1t0VxwSN7bQ_1789993281 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9CBB719540DF; Mon, 21 Sep 2026 12:21:21 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D7F5300106B; Mon, 21 Sep 2026 12:21:19 +0000 (UTC) Date: Mon, 21 Sep 2026 13:21:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Mark Cave-Ayland Cc: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, mtosatti@redhat.com, marcandre.lureau@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org Subject: Re: [PATCH v4 3/9] qom/object.c: introduce object_class_property_add_alias() Message-ID: References: <20260921113559.1299740-1-mark.caveayland@nutanix.com> <20260921113559.1299740-4-mark.caveayland@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260921113559.1299740-4-mark.caveayland@nutanix.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Sep 21, 2026 at 12:35:09PM +0100, Mark Cave-Ayland wrote: > This is eventually intended to be a replacement for object_property_add_alias() > which uses an object property instead of a class property. > > With the advent of class properties, it is possible that QOM may attempt to > set or retrieve the value of an unset alias property. Update the existing > property_get_alias() function to use the null visitor if the alias target has > not been set, property_set_alias() to return an error, and > property_resolve_alias() to return NULL for the same case. > > This ensures that unset class alias properties accessed e.g. via the monitor do > not cause QEMU to crash. > > Signed-off-by: Mark Cave-Ayland > --- > include/qom/object.h | 25 ++++++++++++ > qom/object.c | 97 ++++++++++++++++++++++++++++++++++++++------ > 2 files changed, 110 insertions(+), 12 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|