Re: [PATCH] remoteproc: qcom: q6v5-wcss: remove all subdevices on unbind

[krzk@kernel.org]

On Fri, 18 Sep 2026 12:13:21 +0800, Guangshuo Li wrote:
> q6v5_wcss_probe() registers GLINK, PDM and SSR remoteproc subdevices,
> and may also register a sysmon subdevice. The probe failure path
> removes all of these subdevices, but q6v5_wcss_remove() only removes
> the PDM subdevice.
> 
> As a result, GLINK, SSR and sysmon resources and registrations can
> remain after the WCSS driver is removed.
> 
> Call rproc_del() before tearing down the Qualcomm-specific resources,
> matching the teardown order used by the other Qualcomm Q6 remoteproc
> drivers, and remove the GLINK, sysmon and SSR subdevices together with
> the existing PDM cleanup.
> 
> This issue was found by manual code inspection.
> 
> Fixes: 8a226e2c71bb ("remoteproc: wcss: add support for rpmsg communication")
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---
>  drivers/remoteproc/qcom_q6v5_wcss.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 


You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem, how to document usage of LLM and how what you should not
do if this was posted in a good faith.

Best regards,
Krzysztof