Re: [PATCH v3] dmaengine: loongson: Remove the dev_dbg() output

[Frank Li <Frank.li@oss.nxp.com>]

On Mon, Sep 21, 2026 at 03:16:14PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dmaengine: loongson: unnecessary curly braces around single statement
> --
>
> commit 800bb056df0405c03d12921052d730f7cccef7be
> Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> dmaengine: loongson: Remove the dev_dbg() output
>
> This commit removes the dev_dbg() output from
> loongson2_cmc_dma_issue_pending() since the %pK format modifier is not
> appropriate for general printk output. The debug statement was deemed
> non-essential and is completely removed.
>
> > diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > index 1c9a542edc859..27f8f7a5738d9 100644
> > --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > @@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
> >  	guard(spinlock_irqsave)(&lchan->vchan.lock);
> >
> >  	if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
> > -		dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
> >  		loongson2_cmc_dma_start_transfer(lchan);
> >  	}
>
> [Severity: Low]
> This isn't a bug, but with the removal of the dev_dbg() statement, this if
> block now contains only a single statement. Should the curly braces be
> removed to adhere to the kernel coding style guidelines?

Please fix this also.

Frank

>
> >  }
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260921151312.I8Q8NLnx@linutronix.de?part=1