From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: cryolitia.pukngae@linux.dev, kees+treewide@kernel.org,
DongLin_Lyu@outlook.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atkbd - rate-limit unknown key warnings
Date: Mon, 21 Sep 2026 09:40:00 -0700 [thread overview]
Message-ID: <arFZdtgmZXcK9k1V@google.com> (raw)
In-Reply-To: <20260921131934.677541-1-zhangheng@kylinos.cn>
Hi Zhang,
On Mon, Sep 21, 2026 at 09:19:34PM +0800, Zhang Heng wrote:
> Replace dev_warn() with dev_warn_ratelimited() for unmapped scancode
> warnings, matching the existing rate-limited handling of spurious
> ACK/NAK events in the same function.
I do not think this is needed. Unlike spurious NAK/ACKs pressing keys
are initiated by a person and events are naturally rate-limited.
The solution is to indeed map the key to do nothing:
KEYBOARD_KEY_xx=unknown
Userspace ignores KEY_UNKNOWN events and there are no dmesg logs either.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-09-21 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 13:19 [PATCH] Input: atkbd - rate-limit unknown key warnings Zhang Heng
2026-09-21 16:40 ` Dmitry Torokhov [this message]
2026-09-22 2:12 ` Zhang Heng
2026-09-22 3:38 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arFZdtgmZXcK9k1V@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=DongLin_Lyu@outlook.com \
--cc=cryolitia.pukngae@linux.dev \
--cc=kees+treewide@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.