All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Xiaoyao Li <xiaoyao.li@intel.com>,
	Kai Huang <kai.huang@intel.com>,
	 Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	 Yan Zhao <yan.y.zhao@intel.com>
Subject: Re: [PATCH v3 0/8] KVM: VMX: Harden against interpreting TDX vCPU as vcpu_vmx
Date: Mon, 21 Sep 2026 09:54:44 -0700	[thread overview]
Message-ID: <arFhVLkkGFyGBGI4@google.com> (raw)
In-Reply-To: <178999918502.750661.11881169009752034088.b4-ty@google.com>

On Mon, Sep 21, 2026, Sean Christopherson wrote:
> On Thu, 03 Sep 2026 18:03:45 -0700, Sean Christopherson wrote:
> > Move and rename "all" (read: everything I could find) common helpers out of
> > vmx.c and/or replace their vmx_ prefix with vt_, and then poison to_vmx() for
> > all common .c files to harden KVM against misinterpreting a TDX vCPU as a VMX
> > vCPU, i.e. consuming to_vmx() on a TDX vCPU.  Spotted when working through
> > the bus lock series.
> > 
> > v3:
> >  - Collect tags. [Kai, Xiaoyao, Binbin]
> >  - Move the poisoning to patch 1. [Xiaoyao]
> >  - s/Disallowing/Disallow. [Binbin, Kai]
> >  - s/vmx_needs_pi_wakeup/vt_needs_pi_wakeup. [Xiaoyao]
> > 
> > [...]
> 
> Applied to kvm-x86 vmx, thanks!
> 
> [1/8] KVM: VMX: Disallow using to_vmx() in common VT code
>       https://github.com/kvm-x86/linux/commit/05a0c1e2a525
> [2/8] KVM: VMX: Move the shared "IRQs off" exit handler(s) to common code
>       https://github.com/kvm-x86/linux/commit/903420c26086
> [3/8] KVM: VMX: Move the shared NMI handler/trampoline to common code
>       https://github.com/kvm-x86/linux/commit/81fbafddf6e5
> [4/8] KVM: VMX: Rename posted interrupt prefixes from "vmx" to "vt"
>       https://github.com/kvm-x86/linux/commit/09c6f74ecb86
> [5/8] KVM: VMX: Rename EPT violation handler prefix from "vmx" to "vt"
>       https://github.com/kvm-x86/linux/commit/96a113536fa0
> [6/8] KVM: VMX: Use dummy pseudo-overlay struct for to_vt() and vt_to_vcpu()
>       https://github.com/kvm-x86/linux/commit/881455777a02
> [7/8] KVM: VMX: Move common VT getters/converters to common.h
>       https://github.com/kvm-x86/linux/commit/d238df58b1e1
> [8/8] KVM: VMX: Rename common exit info getters prefixes from "vmx" to "vt"
>       https://github.com/kvm-x86/linux/commit/decbd448b05e

FYI, I'm going to rebase these on top of the TDX bus-lock series[*], i.e. these
hashes are going to change.  I forgot that series needs to got to stable@.

[*] https://lore.kernel.org/all/20260819094903.3060020-1-xiaoyao.li@intel.com

      reply	other threads:[~2026-09-21 16:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  1:03 [PATCH v3 0/8] KVM: VMX: Harden against interpreting TDX vCPU as vcpu_vmx Sean Christopherson
2026-09-04  1:03 ` [PATCH v3 1/8] KVM: VMX: Disallow using to_vmx() in common VT code Sean Christopherson
2026-09-04  2:19   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 2/8] KVM: VMX: Move the shared "IRQs off" exit handler(s) to common code Sean Christopherson
2026-09-04  2:28   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 3/8] KVM: VMX: Move the shared NMI handler/trampoline " Sean Christopherson
2026-09-04  2:30   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 4/8] KVM: VMX: Rename posted interrupt prefixes from "vmx" to "vt" Sean Christopherson
2026-09-04  2:41   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 5/8] KVM: VMX: Rename EPT violation handler prefix " Sean Christopherson
2026-09-04  2:42   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 6/8] KVM: VMX: Use dummy pseudo-overlay struct for to_vt() and vt_to_vcpu() Sean Christopherson
2026-09-04  2:54   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 7/8] KVM: VMX: Move common VT getters/converters to common.h Sean Christopherson
2026-09-04  2:57   ` Binbin Wu
2026-09-04  1:03 ` [PATCH v3 8/8] KVM: VMX: Rename common exit info getters prefixes from "vmx" to "vt" Sean Christopherson
2026-09-04  3:00   ` Binbin Wu
2026-09-21 14:05 ` [PATCH v3 0/8] KVM: VMX: Harden against interpreting TDX vCPU as vcpu_vmx Sean Christopherson
2026-09-21 16:54   ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arFhVLkkGFyGBGI4@google.com \
    --to=seanjc@google.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=xiaoyao.li@intel.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.