All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
	"Darrick J . Wong" <djwong@kernel.org>,
	Joanne Koong <joannelkoong@gmail.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	Hannes Reinecke <hare@suse.de>,
	Daniel Gomez <da.gomez@samsung.com>,
	Pankaj Raghav <p.raghav@samsung.com>,
	Dave Chinner <dchinner@redhat.com>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] iomap: fix error handling regressions
Date: Mon, 21 Sep 2026 14:07:33 -0400	[thread overview]
Message-ID: <arFyZbS_pTpplxWw@bfoster> (raw)
In-Reply-To: <20260921083133.2960-1-parri.andrea@gmail.com>

On Mon, Sep 21, 2026 at 10:31:30AM +0200, Andrea Parri wrote:
> Fix three independent error handling regressions in iomap:
> 
>  - clear the writeback context after a failed ->writeback_submit() call,
>    preventing an already completed ioend from being submitted again;
>  - preserve an iomap iteration error when iomap_fiemap() has a pending
>    extent to emit; and
>  - preserve a direct I/O data path error when sub-block tail zeroing
>    succeeds.
> 
> The fixes have no ordering dependencies and can be applied or backported
> independently.  Each issue was reproduced before and after its respective
> fix.
> 

These all look reasonable to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> Andrea Parri (3):
>   iomap: don't resubmit an ioend after ->writeback_submit() failed
>   iomap: don't lose a fiemap iteration error when emitting the last
>     extent
>   iomap: don't lose a failed direct I/O bio's error when zeroing the
>     tail
> 
>  fs/iomap/direct-io.c | 11 ++++++++---
>  fs/iomap/fiemap.c    |  8 ++++----
>  fs/iomap/ioend.c     | 10 +++++++++-
>  3 files changed, 21 insertions(+), 8 deletions(-)
> 
> 
> base-commit: 93f51579e7df248780214094418f205253383cc5
> -- 
> 2.53.0
> 


      parent reply	other threads:[~2026-09-21 18:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  8:31 [PATCH 0/3] iomap: fix error handling regressions Andrea Parri
2026-09-21  8:31 ` [PATCH 1/3] iomap: don't resubmit an ioend after ->writeback_submit() failed Andrea Parri
2026-09-21 22:29   ` Darrick J. Wong
2026-09-22  5:34     ` Christoph Hellwig
2026-09-22  8:53       ` Andrea Parri
2026-09-22  5:33   ` Christoph Hellwig
2026-09-22  9:03     ` Andrea Parri
2026-09-22 12:29       ` Christoph Hellwig
2026-09-22 19:00         ` Andrea Parri
2026-09-21  8:31 ` [PATCH 2/3] iomap: don't lose a fiemap iteration error when emitting the last extent Andrea Parri
2026-09-21 22:31   ` Darrick J. Wong
2026-09-22  5:34   ` Christoph Hellwig
2026-09-21  8:31 ` [PATCH 3/3] iomap: don't lose a failed direct I/O bio's error when zeroing the tail Andrea Parri
2026-09-21 22:34   ` Darrick J. Wong
2026-09-22  5:36     ` Christoph Hellwig
2026-09-22  9:10       ` Andrea Parri
2026-09-22 12:28         ` Christoph Hellwig
2026-09-22 18:43           ` Andrea Parri
2026-09-21 18:07 ` Brian Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arFyZbS_pTpplxWw@bfoster \
    --to=bfoster@redhat.com \
    --cc=brauner@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=hare@suse.de \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=parri.andrea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.