Re: [PATCH 5/7] ASoC: Intel: sof-function-topology-lib: add I2S support for sof_sdw_get_tplg_files

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

On Tue, Sep 22, 2026 at 05:23:14PM +0800, Bard Liao wrote:

> The Intel SOF SDW machine drive also supports I2S interface. Add related
> supports for the sof_sdw_get_tplg_files() callback.

> +static int get_ssp_tplg_dev(struct device *dev, struct snd_soc_dai_link *dai_link,
> +			    u16 *hdmi_in_mask, int *tplg_dev, char **tplg_dev_name)
> +{
> +	unsigned int ssp_port;
> +
> +	if (sscanf(dai_link->name, "SSP%d", &ssp_port) != 1) {

Should be %u for unsigned, or a regular int for %d.

> +	if (strstr(dai_link->name, "Codec")) {
> +		/*
> +		 * Assume DAI link 0 is jack which is true in all existing
> +		 * machine drivers

How about sof_ssp_amp.c?

> +	} else if (strstr(dai_link->name, "HDMI")) {
> +		*hdmi_in_mask |= BIT(ssp_port);
> +		/* The number of HDMI in dai link is always 2 right now */
> +		if (hweight16(*hdmi_in_mask) != 2)
> +			return -EINVAL;
> +
> +		*tplg_dev = TPLG_DEVICE_SSP_HDMI_IN;
> +		*tplg_dev_name = devm_kasprintf(dev, GFP_KERNEL,
> +						"ssp%x-hdmiin", *hdmi_in_mask);

Not %d?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]