From: Gregory Price <gourry@gourry.net>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Alexandre Ghiti <alex@ghiti.fr>,
akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz,
liam@infradead.org, david@kernel.org, vbabka@kernel.org,
jannh@google.com, chrisl@kernel.org, kasong@tencent.com,
shikemeng@huaweicloud.com, nphamcs@gmail.com,
baoquan.he@linux.dev, baohua@kernel.org, youngjun.park@lge.com,
qi.zheng@linux.dev, shakeel.butt@linux.dev,
axelrasmussen@google.com, yuanchu@google.com,
weixugc@google.com, hannes@cmpxchg.org, mhocko@kernel.org,
yosry@kernel.org, chengming.zhou@linux.dev, kunwu.chan@gmail.com,
tz2294@columbia.edu, hch@lst.de, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: madvise: drop MADV_PAGEOUT folios at swap writeback completion
Date: Tue, 22 Sep 2026 11:22:26 -0400 [thread overview]
Message-ID: <arKdGMrUixIb4spc@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <arJYmwKnEu-djZlK@gremlin>
On Tue, Sep 22, 2026 at 11:44:20AM +0100, Lorenzo Stoakes (ARM) wrote:
> > @@ -554,10 +567,12 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
> > folio_set_workingset(folio);
> > if (pageout) {
> > if (folio_isolate_lru(folio)) {
> > - if (folio_test_unevictable(folio))
> > + if (folio_test_unevictable(folio)) {
> > folio_putback_lru(folio);
> > - else
> > + } else {
> > + madvise_mark_dropbehind(folio);
> > list_add(&folio->lru, &folio_list);
> > + }
> > }
>
> This existing code is utterly horrible can we maybe do some refactoring before
> adding yet more functionality here?
>
> I feel like the 'pay down technical debt first' take I had in THP is pretty
> valid here also.
>
> But also, yeah you DEFINITELY need to separate out patches here.
>
I will post my refactor today, sorry for the delay.
prev parent reply other threads:[~2026-09-22 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:24 [PATCH] mm: madvise: drop MADV_PAGEOUT folios at swap writeback completion Alexandre Ghiti
2026-09-21 15:37 ` David Hildenbrand (Arm)
2026-09-21 21:56 ` Barry Song
2026-09-22 8:56 ` Kairui Song
2026-09-22 10:20 ` David Hildenbrand (Arm)
2026-09-22 10:37 ` Barry Song
2026-09-22 10:47 ` Lorenzo Stoakes (ARM)
2026-09-22 11:10 ` Barry Song
2026-09-22 11:15 ` Lorenzo Stoakes (ARM)
2026-09-22 11:36 ` Barry Song
2026-09-22 11:26 ` David Hildenbrand (Arm)
2026-09-22 20:55 ` Barry Song
2026-09-23 8:44 ` David Hildenbrand (Arm)
2026-09-23 9:35 ` Kairui Song
2026-09-23 9:46 ` David Hildenbrand (Arm)
2026-09-23 10:14 ` Kairui Song
2026-09-23 16:21 ` KunWu Chan
2026-09-24 9:19 ` Alexandre Ghiti
2026-09-24 9:10 ` Alexandre Ghiti
2026-09-22 10:44 ` Lorenzo Stoakes (ARM)
2026-09-22 13:22 ` Alexandre Ghiti
2026-09-22 15:22 ` Gregory Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arKdGMrUixIb4spc@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kasong@tencent.com \
--cc=kunwu.chan@gmail.com \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=nphamcs@gmail.com \
--cc=qi.zheng@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=tz2294@columbia.edu \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yosry@kernel.org \
--cc=youngjun.park@lge.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.