Re: [PATCH 07/14] xfs: fix ondisk symlink target validation in xrep_dinode_check_dfork

[Dave Chinner <dgc@kernel.org>]

On Sun, Sep 20, 2026 at 11:16:48PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> LOLLM noticed that online repair of a broken symlink file could fail
> unnecessarily if a local-format symlink target isn't null terminated.
> The ondisk target isn't required to be null terminated, but repair
> enforces that anyway because it uses the validator for the incore
> symlink target.  (The incore buffer is always null-terminated).  Fix
> this by reverting the changes to xfs_symlink_shortform_verify and adding
> an ondisk-specific helper in inode_repair.c.
> 
> Cc: <stable@vger.kernel.org> # v6.8
> Fixes: e744cef2060559 ("xfs: zap broken inode forks")
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> Assisted-by: LOLLM # finding obvious bugs
> ---
>  fs/xfs/libxfs/xfs_symlink_remote.h |    2 +-
>  fs/xfs/libxfs/xfs_inode_fork.c     |    4 +---
>  fs/xfs/libxfs/xfs_symlink_remote.c |    8 ++++++--
>  fs/xfs/scrub/inode_repair.c        |   26 +++++++++++++++++++++++++-
>  4 files changed, 33 insertions(+), 7 deletions(-)

Just tripped over this independently looking at local format symlink
verification for inode log item recovery. Fix looks good.

Reviewed-by: Dave Chinner <dgc@kernel.org>

-- 
Dave Chinner
dgc@kernel.org