Re: [linux-next:master 4776/8910] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2974 axienet_probe() warn: platform_get_irq() does not return zero

[Dan Carpenter <error27@gmail.com>]

On Wed, Sep 23, 2026 at 02:35:58PM +0700, Bui Duc Phuc wrote:
> It seems the analysis tool may have been mistaken in this case.
> 
> 
> > bb2b71024976a39 bui duc phuc             2026-09-09 @2974               if (!lp->rx_irq || !lp->tx_irq) {
> >
> > These should be checks for negative instead of zero.
> >
> 
> The check is intended for the case where rx_irq and tx_irq are obtained from
> irq_of_parse_and_map(), which returns 0 on failure.
> 
> > 95219aa538e11d5 Srikanth Thokala         2015-05-05  2975                       dev_err(&pdev->dev, "could not determine irqs\n");
> > bb2b71024976a39 bui duc phuc             2026-09-09  2976                       return -EINVAL;
> > 8a3b7a252dca9fb Daniel Borkmann          2012-01-19  2977               }
> > bb2b71024976a39 bui duc phuc             2026-09-09  2978               if (lp->rx_irq < 0)
> >
> 
> This check handles the error return from platform_get_irq()

Ah.  Right.  That works.  Sorry.

I kind of hate that we still have irq functions that return zero on
error instead of a normal error code.  It's a historical artifact.

regards,
dan carpenter