From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52F0CC982FA for ; Wed, 23 Sep 2026 08:34:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x9IQe-0004uf-4Q; Wed, 23 Sep 2026 04:34:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9IQY-0004tO-0p for qemu-devel@nongnu.org; Wed, 23 Sep 2026 04:34:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9IQW-0006hO-6S for qemu-devel@nongnu.org; Wed, 23 Sep 2026 04:34:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790152442; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wz0gHUDYh9XwZr2RwmjPunVU0+k8NgvgcNpgOuU6tOk=; b=ZEGtUCZcRWa01qN/fvcjsuPbiJGJ7ISeS9CuxCRuj7acAMrAcYQsAE8P+gswSp1+ZgPBEH sewVT7a849zrsuwvi+rfSpHegZ1wiBsbRylxwlZCXlNm+GApop9YWuwRG7dOpECXrkvxHg OZhjcQcdlqLdnVkbhqERhFwbb0WXoTg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-2-s1mocNOaaNodoyF-P4wQ-1; Wed, 23 Sep 2026 04:33:58 -0400 X-MC-Unique: 2-s1mocNOaaNodoyF-P4wQ-1 X-Mimecast-MFC-AGG-ID: 2-s1mocNOaaNodoyF-P4wQ_1790152434 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AF6E118413B9; Wed, 23 Sep 2026 08:33:53 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B904A3000223; Wed, 23 Sep 2026 08:33:44 +0000 (UTC) Date: Wed, 23 Sep 2026 09:33:41 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Bibo Mao , Xianglai Li , Laurent Vivier , Palmer Dabbelt , Chao Liu , qemu-arm@nongnu.org, Alistair Francis , Laurent Vivier , Pierrick Bouvier , Weiwei Li , Daniel Henrique Barboza , Zhao Liu , Peter Maydell , Fabiano Rosas , Song Gao <17746591750@163.com>, Markus Armbruster , Liu Zhiwei , qemu-riscv@nongnu.org, Stafford Horne , Brian Cain , Jiaxun Yang , Max Filippov , Philippe Mathieu-Daude , Paolo Bonzini , Eric Blake Subject: Re: [PATCH v2 9/9] qapi: return MachineInfo typename from query-machines Message-ID: References: <20260922215533.641-1-luoyonggang@gmail.com> <20260922215533.641-10-luoyonggang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260922215533.641-10-luoyonggang@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Sep 23, 2026 at 05:55:32AM +0800, Yonggang Luo wrote: > query-machines returned only the -M name, so management apps inferred > the QOM type as that name plus "-machine". A prefixed type such as > arm-virt-11.1-machine no longer matches -M virt-11.1. Return the QOM > type in MachineInfo typename from object_class_get_name() in > qmp_query_machines(). test_query_machines_typename checks that > qom-list-properties accepts it. > > Signed-off-by: Yonggang Luo > --- > hw/core/machine-qmp-cmds.c | 1 + > qapi/machine.json | 6 +++- > tests/qtest/qom-test.c | 65 ++++++++++++++++++++++++++++++++++---- > 3 files changed, 65 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|