From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
linux-scsi@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.garry@linux.dev>
Subject: Re: [PATCH v5 04/10] scsi: scsi_debug: Evaluate scsi_debug_lbp() only once
Date: Wed, 23 Sep 2026 11:54:10 +0200 [thread overview]
Message-ID: <arOhUIcsod1ivn24@mayhem.fritz.box> (raw)
In-Reply-To: <20260921154015.2971990-16-cassel@kernel.org>
On Mon, Sep 21, 2026 at 05:40:20PM +0200, Niklas Cassel wrote:
> if (sdebug_dev_is_zoned(devip) ||
> sdebug_dix ||
> - scsi_debug_lbp()) {
> + lbp) {
Nit, lbp would now perfectly fit on the previous line.
> sdeb_meta_write_lock(sip);
> meta_data_locked = true;
> }
> @@ -4975,7 +4976,7 @@ static int corrupt_lbas(struct sdebug_dev_info *devip, u64 lba, u32 num,
> goto out_unlock;
> }
>
> - if (scsi_debug_lbp() &&
> + if (lbp &&
> (!map_state(sip, lba, &num_mapped) || num > num_mapped)) {
Same
> pr_err("can't modify unmapped logical blocks: %llu:%u",
> lba, num);
> @@ -5035,6 +5036,7 @@ static int resp_write_dt0(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
> struct sdeb_store_info *sip = devip2sip(devip, true);
> u8 *cmd = scp->cmnd;
> bool meta_data_locked = false;
> + bool lbp = scsi_debug_lbp();
>
> if (unlikely(sdebug_opts & SDEBUG_OPT_UNALIGNED_WRITE &&
> atomic_read(&sdeb_inject_pending))) {
> @@ -5102,7 +5104,7 @@ static int resp_write_dt0(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
>
> if (sdebug_dev_is_zoned(devip) ||
> (sdebug_dix && scsi_prot_sg_count(scp)) ||
> - scsi_debug_lbp()) {
> + lbp) {
> sdeb_meta_write_lock(sip);
> meta_data_locked = true;
> }
And here as well
next prev parent reply other threads:[~2026-09-23 9:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:40 [PATCH v5 00/10] scsi: scsi_debug: fix zoned write validation Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 01/10] scsi: scsi_debug: Refuse a zoned device with a non-zero lowest aligned LBA Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 02/10] scsi: scsi_debug: Make atomic writes and ZBC emulation mutually exclusive Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 03/10] scsi: scsi_debug: Take the zone metadata lock before the data lock Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 04/10] scsi: scsi_debug: Evaluate scsi_debug_lbp() only once Niklas Cassel
2026-09-21 15:53 ` John Garry
2026-09-23 9:54 ` Johannes Thumshirn [this message]
2026-09-21 15:40 ` [PATCH v5 05/10] scsi: scsi_debug: Report the residual of a write Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 06/10] scsi: scsi_debug: Enforce physical block alignment of zoned writes Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 07/10] scsi: scsi_debug: Do not write a partial physical block to a zoned device Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 08/10] scsi: scsi_debug: Advance the write pointer over the data written Niklas Cassel
2026-09-21 15:40 ` [PATCH v5 09/10] scsi: scsi_debug: Map the region written by WRITE ATOMIC (16) Niklas Cassel
2026-09-21 15:50 ` John Garry
2026-09-24 11:10 ` Niklas Cassel
2026-09-25 9:32 ` John Garry
2026-09-21 15:40 ` [PATCH v5 10/10] scsi: scsi_debug: Validate the access parameters of " Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arOhUIcsod1ivn24@mayhem.fritz.box \
--to=johannes.thumshirn@wdc.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=john.garry@linux.dev \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.