All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: "Markku Ahvenjärvi" <mankku@gmail.com>
Cc: qemu-devel@nongnu.org, Klaus Jensen <its@irrelevant.dk>,
	Jesper Devantier <foss@defmacro.it>,
	qemu-block@nongnu.org
Subject: Re: [PATCH 1/3] hw/nvme: prevent cq_pending underflow
Date: Wed, 23 Sep 2026 08:39:28 -0600	[thread overview]
Message-ID: <arPkoItGqH5MY7TQ@kbusch-mbp> (raw)
In-Reply-To: <20260923-nvme-intx-fixes-v1-1-fbf0e4e567a5@gmail.com>

On Wed, Sep 23, 2026 at 03:20:02PM +0300, Markku Ahvenjärvi wrote:
> cq_pending counts interrupt-enabled completion queues with unconsumed
> entries. nvme_cq_notifier() and nvme_process_db() decrement it whenever
> a CQ becomes empty, but they may also process a notification or doorbell
> write for a CQ that was already empty.

Is there a host actually doing this? If the host writes a doorbell
register to an empty queue, that is a spec violation on the host and the
controller should fail the queue. If it's not the admin queue, then the
controller should to send the Invalid Doorbell Write Value AEN
completion.


  reply	other threads:[~2026-09-23 14:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 12:20 [PATCH 0/3] hw/nvme: fix legacy INTx handling Markku Ahvenjärvi
2026-09-23 12:20 ` [PATCH 1/3] hw/nvme: prevent cq_pending underflow Markku Ahvenjärvi
2026-09-23 14:39   ` Keith Busch [this message]
2026-09-24  6:56     ` Markku Ahvenjärvi
2026-09-24 17:57       ` Keith Busch
2026-09-25  7:32         ` Markku Ahvenjärvi
2026-10-05  5:54           ` Markku Ahvenjärvi
2026-10-05 13:09             ` Keith Busch
2026-09-23 12:20 ` [PATCH 2/3] hw/nvme: fix missed CQ updates Markku Ahvenjärvi
2026-09-23 12:20 ` [PATCH 3/3] hw/nvme: clear interrupts on controller reset Markku Ahvenjärvi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arPkoItGqH5MY7TQ@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=foss@defmacro.it \
    --cc=its@irrelevant.dk \
    --cc=mankku@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.