All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Elijah Newren <newren@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH REGRESSION] builtin/rebase: allow user to amend committed conflicts again
Date: Wed, 23 Sep 2026 20:38:58 +0200	[thread overview]
Message-ID: <arQcwhuMtcZNoAmI@pks.im> (raw)
In-Reply-To: <xmqqzex7akcv.fsf@gitster.g>

On Wed, Sep 23, 2026 at 11:33:20AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > It makes me wonder whether we can instead fix git-commit(1) itself to
> > maybe not reset authorship information. But that's probably a much
> > harder change to do, and probably it would make the mess that we have
> > with the ".git/rebase-merge" state directory even bigger.
> 
> I do not think I understand what you mean by "fix git-commit".  Make
> it pay attention to some file in .git/ directory and override the
> authorship information over what it usually uses, and make sure it
> removes that file after it consumed it, or something like that?

Yeah, exactly. The fact that it resets authorship information of a
conflicting commit is probably quite surprising overall as an outcome.
It's arguable whether this even qualifies as "fix", as in the end
git-commit(1) simply does what it always does. But it probably doesn't
match the expected outcome in many cases.

Patrick

  reply	other threads:[~2026-09-23 18:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 13:16 [PATCH REGRESSION] builtin/rebase: allow user to amend committed conflicts again Patrick Steinhardt
2026-09-23 14:02 ` Phillip Wood
2026-09-23 14:22   ` Phillip Wood
2026-09-23 17:33     ` Junio C Hamano
2026-09-23 17:49       ` Elijah Newren
2026-09-24  6:10         ` Johannes Sixt
2026-09-27  8:04           ` Jiang Xin
2026-09-23 17:48 ` Elijah Newren
2026-09-23 17:59   ` Junio C Hamano
2026-09-23 18:23   ` Patrick Steinhardt
2026-09-23 18:33     ` Junio C Hamano
2026-09-23 18:38       ` Patrick Steinhardt [this message]
2026-09-23 19:11       ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arQcwhuMtcZNoAmI@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.