All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Yoo <harry@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@kernel.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Hao Li <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
	 David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	linux-mm@kvack.org
Subject: Re: [PATCH] slab: Remove slab_folio()
Date: Wed, 23 Sep 2026 20:45:58 +0100	[thread overview]
Message-ID: <arQqdeTaYf08TYl0@thinkstation> (raw)
In-Reply-To: <20260923183655.3364885-1-willy@infradead.org>

On Wed, Sep 23, 2026 at 07:36:51PM +0100, Matthew Wilcox (Oracle) wrote:
> This is the final step of divorcing struct slab from struct folio.
> It's still tied to struct page, but there are no more mentions of folios
> in the slab code.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---

Looks good to me,
Reviewed-by: Harry Yoo (Meta) <harry@kernel.org>

With a tiny little nit:

> @@ -184,15 +169,16 @@ static inline struct slab *page_slab(const struct page *page)
>   * slab_page - The first struct page allocated for a slab
>   * @s: The slab.
>   *
> - * A convenience wrapper for converting slab to the first struct page of the
> - * underlying folio, to communicate with code not yet converted to folio or
> - * struct slab.
> + * A convenience wrapper for returning the first page allocated to this slab.
> + * to communicate with code not yet converted to struct slab.
    * A convenience wrapper for returning the first "struct" page allocated to this
    * "slab" to communicate with code not yet converted to struct slab.
>   */

Perhaps you meant this?

-- 
Cheers,
Harry / Hyeonggon


  parent reply	other threads:[~2026-09-23 19:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 18:36 [PATCH] slab: Remove slab_folio() Matthew Wilcox (Oracle)
2026-09-23 19:19 ` Gregory Price
2026-09-23 19:45 ` Harry Yoo [this message]
2026-09-23 20:11   ` Vlastimil Babka (SUSE)
2026-09-23 20:41     ` Matthew Wilcox
2026-09-24  7:41       ` Vlastimil Babka (SUSE)
2026-09-24 17:43 ` Harry Yoo (Meta)
2026-09-25  8:08 ` Vlastimil Babka (SUSE)
2026-09-25  8:35 ` Hao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arQqdeTaYf08TYl0@thinkstation \
    --to=harry@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=hao.li@linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.