All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: SJ Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/damon/core: preserve the caller's quota in damon_new_scheme()
Date: Wed, 23 Sep 2026 23:46:27 +0200	[thread overview]
Message-ID: <arRHl5blMrrmvhkU@gmail.com> (raw)
In-Reply-To: <20260922120845.44460-1-sj@kernel.org>

On Tue, Sep 22, 2026 at 05:08:44AM +0100, SJ Park wrote:
> To calrify my opinion more, "caller's quota" feels unclear to me.  I hope it to
> be more clear that it means "the quota that is passed as a parameter to the
> function".

I've made it explicit that this means the quota passed as a parameter
to damon_new_scheme().

> > > 
> > > damon_commit_ctx() first copies the running context into a temporary
> > > context for validating the proposed parameters.
> 
> I'd prefer using the term, 'commit' instead of 'copies' for clarity.

Changed to "commit" for the context operation.

> Now I understand you added the comment for commit 60bd24f272d0.  I think Fixes:
> should also be 60bd24f272d0.

Agreed. I checked the diff and earlier callers. That commit first passes
the running context as the source. v2 uses it with a plain Cc: stable.

The LLM suggested the wrong tag, and I didn't notice it when checking it.

v2 is rebased on mm-new and passes all 46 KUnit tests on x86-64 and
i386. I'll send it soon.

Thanks,
Karl


  reply	other threads:[~2026-09-23 21:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  0:30 [PATCH 0/2] mm/damon: preserve quota state when constructing schemes Karl Mehltretter
2026-09-21  0:30 ` [PATCH 1/2] mm/damon/core: preserve the caller's quota in damon_new_scheme() Karl Mehltretter
2026-09-21  0:38   ` sashiko-bot
2026-09-21 17:11   ` SJ Park
2026-09-22 12:08     ` SJ Park
2026-09-23 21:46       ` Karl Mehltretter [this message]
2026-09-24  7:33         ` SJ Park
2026-09-21  0:30 ` [PATCH 2/2] mm/damon/tests/core-kunit: test preservation of caller quota state Karl Mehltretter
2026-09-21  0:36   ` sashiko-bot
2026-09-22 12:28   ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arRHl5blMrrmvhkU@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.