From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 12/12] xfs: avoid cross-rtgroup reaping after a repair
Date: Wed, 23 Sep 2026 22:57:09 -0700 [thread overview]
Message-ID: <arS7tTCQGhyHjoou@infradead.org> (raw)
In-Reply-To: <179014159798.1875436.7915121855965899039.stgit@frogsfrogsfrogs>
On Tue, Sep 22, 2026 at 11:03:52PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM notices that the extents stored in a xrtb_bitmap (aka xfs_rtblock
> bitmap) can span multiple rtgroups due to two circumstances. The first
> is that the size of an rtgroup is an exact power of two, which means
> that rtgroups are adjacent in the segmented xfs_rtblock_t address space.
> This is fairly common to reduce the amount of multiplication and
> division needed to handle space on the rt volume.
>
> The second is that (unlike in the original rtgroups design), rtgroups do
> not have fixed-location metadata like AGs do, which means that there's
> nothing to force a break between rtgroups.
>
> Therefore, we must loop through the rtgroups in xreap_rtmeta_extent to
> avoid running off the end of an rtgroup while reaping.
This fix looks good.
Sashiko complains this could use some additional input sanitization,
though.
next prev parent reply other threads:[~2026-09-24 5:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 5:57 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Darrick J. Wong
2026-09-23 6:01 ` [PATCH 01/12] xfs: compute the correct fdblocks/frextents for repair when they're negative Darrick J. Wong
2026-09-23 6:29 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 02/12] xfs: mark cow extents bad if there's no rmap mapping for them Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 03/12] xfs: clear the symlink zapped flag if inline symlink is ok Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 04/12] xfs: reinitialize dquot block if non-first dquot can't load Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 05/12] xfs: fix inode btree repair when a cluster is larger than a chunk Darrick J. Wong
2026-09-24 5:50 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 06/12] xfs: fix integer overflow problem when setting large free areas Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-24 19:04 ` Darrick J. Wong
2026-09-23 6:02 ` [PATCH 07/12] xfs: fix buffer overflow in corrupt inline attr structure Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 08/12] xfs: actually report corrupt xattrs as XFAIL during cross-referencing Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 09/12] xfs: improve dir block reporting when cross-referencing dirents to pptrs Darrick J. Wong
2026-09-24 5:52 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 10/12] xfs: fix unnecessary dapos truncation in xchk_dir_walk Darrick J. Wong
2026-09-24 5:54 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 11/12] xfs: actually lock the metafile reservation when adjusting after repair Darrick J. Wong
2026-09-24 5:55 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 12/12] xfs: avoid cross-rtgroup reaping after a repair Darrick J. Wong
2026-09-24 5:57 ` Christoph Hellwig [this message]
2026-09-24 19:34 ` Darrick J. Wong
2026-10-05 10:05 ` Carlos Maiolino
2026-10-05 14:40 ` Darrick J. Wong
2026-10-05 18:06 ` [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arS7tTCQGhyHjoou@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.