From: Gao Xiang <xiang@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Gao Xiang <xiang@kernel.org>,
Giuseppe Scrivano <gscrivan@redhat.com>,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
amir73il@gmail.com, Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v5 1/2] fs: rename vfs_get_super() to get_tree_super() and export it
Date: Thu, 24 Sep 2026 06:28:20 +0200 [thread overview]
Message-ID: <arSm5OXgLD0xkTsv@MacBookPro.fritz.box> (raw)
In-Reply-To: <20260825-gorilla-zuhilfenahme-unfug-4b81185496a3@brauner>
Hi Christian,
On Tue, Aug 25, 2026 at 02:32:48PM +0200, Christian Brauner wrote:
> On Tue, Aug 11, 2026 at 11:44:20PM +0800, Gao Xiang wrote:
> > (+ cc vfs maintainers)
> >
> > Hi,
> >
> > On Tue, Aug 11, 2026 at 09:10:50AM +0200, Giuseppe Scrivano wrote:
> > > vfs_get_super() already implements the common get_tree pattern of
> > > looking up an existing superblock via a test callback and initialising
> > > a new one with fill_super otherwise, but it is private to fs/super.c
> > > and only reachable through the get_tree_nodev()/get_tree_single()/
> > > get_tree_keyed() wrappers, none of which let a filesystem supply its
> > > own test callback.
> > >
> > > Rename it to get_tree_super() and export it so filesystems that need a
> > > custom superblock matching policy can reuse it directly instead of
> > > open-coding sget_fc() + fill_super(). No functional change.
> > >
> > > This is a preparatory fix for the next patch.
> > >
> > > Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
> >
> > With the new vfs_get_super() helper, it seems much cleaner compared
> > to the previous versions.
>
> I'll add this patch to the vfs-7.3.super tree post -rc1 and then you can
> pull it in. Thanks!
friendly ping.. since I'm working on 7.4 cycle too, could you add the
latest v6 series to vfs-7.4.super so I could pull it in too?
https://lore.kernel.org/r/20260812142907.1010046-1-gscrivan@redhat.com
Thanks,
Gao Xiang
>
next prev parent reply other threads:[~2026-09-24 4:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 7:10 [PATCH v5 0/2] erofs: share the superblock for file-backed mounts Giuseppe Scrivano
2026-08-11 7:10 ` [PATCH v5 1/2] fs: rename vfs_get_super() to get_tree_super() and export it Giuseppe Scrivano
2026-08-11 15:44 ` Gao Xiang
2026-08-11 15:59 ` Giuseppe Scrivano
2026-08-25 12:32 ` Christian Brauner
2026-08-25 13:07 ` Gao Xiang
2026-09-24 4:28 ` Gao Xiang [this message]
2026-08-11 7:10 ` [PATCH v5 2/2] erofs: reuse superblock for file-backed mounts Giuseppe Scrivano
2026-08-11 15:31 ` Gao Xiang
2026-08-11 15:57 ` Giuseppe Scrivano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arSm5OXgLD0xkTsv@MacBookPro.fritz.box \
--to=xiang@kernel.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=gscrivan@redhat.com \
--cc=jack@suse.cz \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.