All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Matthias Goergens <matthias.goergens@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Theodore Ts'o <tytso@mit.edu>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MAINTAINERS: document the branch in git T: entries
Date: Fri, 25 Sep 2026 11:05:00 +0200	[thread overview]
Message-ID: <arY5PNvhEdyx1W4u@ryzen> (raw)
In-Reply-To: <2c05bf39-7e04-4cc7-9926-3cbf673865b5@kernel.org>

Hello Matthias,

On Thu, Sep 24, 2026 at 10:22:32AM +0200, Krzysztof Kozlowski wrote:
> > @@ -30,6 +30,8 @@ Descriptions of section entries and preferred order
> >         See Documentation/maintainer/maintainer-entry-profile.rst for details.
> >  	T: *SCM* tree type and location.
> >  	   Type is one of: git, hg, quilt, stgit, topgit
> > +	   A git entry may name a branch after the URL; name one when
> > +	   development does not happen on the repository's HEAD.

I like the idea of what you are working on.

But one thing crossed my mind.

If we look in:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Next/Trees

You will see that for most trees, e.g. ext4.git, the same tree is specified
twice:
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git#fixes
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git#dev

That is because the most logical thing is to use the same tree, but obviously
you need different branches, if it is new development or a fix.


memblock even specify multiple entries in MAINTAINERS:
https://github.com/torvalds/linux/blob/v7.3-rc4/MAINTAINERS#L17035-L17036

memblock seems to be unique here though, and I don't like the idea of having
multiple T: entries for each branch in the same tree.

Possibly we could allow multiple branches to be specified after the tree,
but I'm not sure if that is a good idea.

A fix is usually merged within a week, so a developer should not really
need to think about "fixes" branch. They should just base it on latest
SHA1 in Linus's tree.


> What contributors need is the branch feeding next, because this is the
> base for them.

I think you are right.

Possibly the documentation should be updated to differentiate the "strictly
a fix / regression in recent release" case versus "new development" case...
but such documentation is hard to write in a generic way. (Not all fixes
might be so important that they deserve to be queued for -fixes.)

But we should probably try to add something to submitting-patches doc which
makes this distinction a bit clearer for a beginner.


Kind regards,
Niklas

      parent reply	other threads:[~2026-09-25  9:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  3:35 [PATCH 1/2] MAINTAINERS: document the branch in git T: entries Matthias Goergens
2026-09-24  3:35 ` [PATCH 2/2] docs: submitting-patches: mention the branch in " Matthias Goergens
2026-09-24  8:24   ` Krzysztof Kozlowski
2026-09-24  8:22 ` [PATCH 1/2] MAINTAINERS: document the branch in git " Krzysztof Kozlowski
2026-09-24  8:23   ` Krzysztof Kozlowski
2026-09-25  9:05   ` Niklas Cassel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arY5PNvhEdyx1W4u@ryzen \
    --to=cassel@kernel.org \
    --cc=corbet@lwn.net \
    --cc=krzk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.goergens@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.